linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
To: "Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org"
	<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
	"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org"
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	"grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org"
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	"rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org"
	<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org"
	<alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
	"lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org"
	<lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>
Subject: Re: [PATCH v7 11/12] davinci: add tnetv107x evm backlight device
Date: Fri, 10 Dec 2010 08:56:28 -0800	[thread overview]
Message-ID: <87aakdd0sj.fsf@deeprootsystems.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930247CD8CE8-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org> (Sekhar Nori's message of "Fri, 10 Dec 2010 21:31:59 +0530")

"Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org> writes:

> On Thu, Dec 09, 2010 at 20:28:41, Chemparathy, Cyril wrote:
>> On 12/09/2010 06:00 AM, Nori, Sekhar wrote:
>> > On Thu, Dec 09, 2010 at 14:25:49, Nori, Sekhar wrote:
>> >
>> >> This call should simply return if machine is not tnetv107x EVM.
>> >>
>> >> I didn't follow the entire series but wondering why
>> >> platform device registration should be a late init call.
>> >> Typically the driver probe can be made a late init call
>> >> in case of init sequence dependencies.
>> >
>> > I meant driver init, not probe.
>>
>> This was done to handle driver dependencies, and is meant to be
>> temporary (until a real driver dependency framework comes in).
>>
>> Please see [1] for a bit more of background on changing drivers to use
>> module_init().
>
> Hmm, okay. Please include a check for machine in that case.
>

Sekhar is right.  

Today, we don't (can't) build this machine with others for a couple
reasons, but we're moving towards removing those restrictions, so when
this machine is included in a binary with others, it needs to check.

Thanks,

Kevin

  parent reply	other threads:[~2010-12-10 16:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 14:51 [PATCH v7 00/12] tnetv107x ssp drivers Cyril Chemparathy
     [not found] ` <1291733522-3626-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-07 14:51   ` [PATCH v7 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
     [not found]     ` <1291733522-3626-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-11  0:13       ` Kevin Hilman
2010-12-07 14:51   ` [PATCH v7 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-12-07 14:51   ` [PATCH v7 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-12-07 14:51   ` [PATCH v7 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
     [not found]     ` <1291733522-3626-5-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-31  6:26       ` Grant Likely
2010-12-07 14:51   ` [PATCH v7 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-12-07 14:51   ` [PATCH v7 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
     [not found]     ` <1291733522-3626-7-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-07 15:22       ` Mark Brown
     [not found]         ` <20101207152222.GD9689-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-12-07 16:46           ` Cyril Chemparathy
2010-12-07 14:51   ` [PATCH v7 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-12-07 14:51   ` [PATCH v7 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
     [not found]     ` <1291733522-3626-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-31  6:16       ` Grant Likely
2010-12-07 14:51   ` [PATCH v7 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-12-07 14:52   ` [PATCH v7 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-12-07 14:52   ` [PATCH v7 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
     [not found]     ` <1291733522-3626-12-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-09  8:55       ` Nori, Sekhar
     [not found]     ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1@dbde02.ent.ti.com>
     [not found]       ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-09 11:00         ` Nori, Sekhar
     [not found]       ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD84F4@dbde02.ent.ti.com>
     [not found]         ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD84F4-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-09 14:58           ` Cyril Chemparathy
     [not found]             ` <4D00EEA1.8070201-l0cyMroinI0@public.gmane.org>
2010-12-10 16:01               ` Nori, Sekhar
     [not found]                 ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD8CE8-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-10 16:56                   ` Kevin Hilman [this message]
2010-12-07 14:52   ` [PATCH v7 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
2010-12-11  0:19 ` [PATCH v7 00/12] tnetv107x ssp drivers Kevin Hilman
     [not found]   ` <87r5dp6tzv.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-12-11 12:42     ` Mark Brown
     [not found]       ` <20101211124242.GE9380-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-12-30 21:05         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aakdd0sj.fsf@deeprootsystems.com \
    --to=khilman-1d3hcaltpluheniveurvkkeocmrvltnr@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).