From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.84.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795080397; b=kyD3WZHCPBTzNW810dfLvrB3JWKP9NmlWpZm17u0KlQ9YKPVx0GHakk69NcYC3NlVlmX IbNGDEt1qNw7KfZSYwQ3060zgm2/WNyynNRSxO453+uLHSUS8h67YXCkMPktwnS2nKUO0 uEWY+bNAuMvGc1JnkJgN75UDdNOouqLfVal8wNEf90LcAMSc3aa32eUjnN6sBWaeKkmJ8 G5+ybzzWpJZNJu2g6ear4PeFAefiw7mzY2ejXBftWV/svKdZIE/gbRGldSoPytXgXC3mR I9tEo37Ek4Su6fJyoA3er2/gmPl2R7xFSUA321xm8yT68NHQNZBvAZXQouZl4q8OWYQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795080397; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:In-Reply-To:References:User-Agent:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding: X-Last-TLS-Session-Version; bh=/z7BAnG7MZSAVYRW5pPZLxA05bNqQ3NUtrJbGTCFDWo=; b=icXWSiZ6tCUwLhZNn3/IWOruZfeHy9Kc6PFCjGQpd9MO/TcGEwUXhrbCXvbbyq6pL6Ta 6F3FJ3jP8hTGKJp9562OHDT18McTzWvEKjbAc/efWdfLffm7CCzAQ509xmnnfd3lFnr+7 GBCmzCaoPbjytTEwJibrVJZuHYsMWE4tkoyYmKax9gWOEie5j7RolaqtkyimLayN8UtRn E4h8mF7mb5hj42Qz+OvR1rd9I1D2mjelWx018QvidpMWL0chflarE+BXLu9/Lzf/aj8Hx 7NS3QgzMH9NAPLZkNClstdrudwvrpk9B77m8+/RsOH16/+QWtbS5ZqkihUhQLiRw8Ew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Cz9JAfUU; arc=none smtp.remote-ip=185.246.84.56 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4767606A324 for ; Thu, 19 Nov 2026 09:26:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B4767606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Cz9JAfUU Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 584BB1A170C; Thu, 19 Nov 2026 09:26:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 24B5B60237; Thu, 19 Nov 2026 09:26:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 372E711BC1FF7; Thu, 19 Nov 2026 10:26:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795080390; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=/z7BAnG7MZSAVYRW5pPZLxA05bNqQ3NUtrJbGTCFDWo=; b=Cz9JAfUU7IyztCLVofDhmCUhQWcGYKI0HmupitglhbNt8Ay4Hkm7G7BPIhHVA7mPmGRq2v v4OnXjpy1WnIdP/JLgPuWvD/0AwiaPVh5aDImotDmfmllARdNxV/SPL/bofqQCLjBeInU0 cQsFdO6gPvZL9sGKVITTIMM7PM9eawYPD0Pv1YN9a318KmLJ5cBh/310lntmvKo2ztuvxk e3eVpzS877O1iX5V9BLJkufMaChuJ0PCpsohkpmc5D/nHpdAlqJRxHNyDtlp3nHAJCnZl4 C/o5UdXRbPnrR1sqQ1n6zlz0jMFt5wEGsJ82bVVsD3xO52hZXOtZj1ECCFpsFg== From: Miquel Raynal To: Mikhail Kshevetskiy Cc: Lorenzo Bianconi , Ray Liu , Mark Brown , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: airoha: Explicitly prevent continuous reads In-Reply-To: <37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu> (Mikhail Kshevetskiy's message of "Wed, 18 Nov 2026 21:37:21 +0300") References: <20261118-winbond-upstreaming-airoha-cont-read-v1-1-acc0b6410868@bootlin.com> <37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Thu, 19 Nov 2026 10:26:26 +0100 Message-ID: <87h5hdf9z1.fsf@bootlin.com> X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Mikhail, On 18/11/2026 at 21:37:21 +03, Mikhail Kshevetskiy wrote: > Hello Miquel, > > I think the patch is bad for the following reasons: > * As I know there is no CS issue with Airoha controller. It works properl= y. > * Airoha controller supports large reads (but only in PIO=C2=A0 mode). Th= us > =C2=A0 continuous reading may work properly. Unfortunately PIO reading se= veral > =C2=A0 times slower than DMA reading. > * DMA reading is much faster, but can't be used for continuous reading. > =C2=A0 Maximum transfer size is 8191 bytes. > > Thus for new Airoha controllers (en7523, an7581 and newer) it's better do > not use continuous reading and read pages using DMA. Old controllers (like > en7512) does not support DMA, so they can benefit from continuous mode > reading. I had understood that the problem was CS handling. Therefore, the approach proposed here is not a good solution, let's drop that patch. Thanks for the feedback, Miqu=C3=A8l