From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] SPI DaVinci: SPI master driver for DaVinci/DA8xx Date: Tue, 05 Jan 2010 16:46:41 -0800 Message-ID: <87iqbgnjpq.fsf@deeprootsystems.com> References: <1261000938-1897-1-git-send-email-s-paulraj@ti.com> <878wccqfmp.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, s-paulraj-l0cyMroinI0@public.gmane.org To: Grant Likely Return-path: In-Reply-To: (Grant Likely's message of "Tue\, 5 Jan 2010 17\:41\:42 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Grant Likely writes: > On Tue, Jan 5, 2010 at 4:46 PM, Kevin Hilman > wrote: >> s-paulraj-l0cyMroinI0@public.gmane.org writes: >> >>> From: Sandeep Paulraj >>> >>> This patch adds support for a SPI master driver for the >>> DaVinci series of SOCs >>> >>> Signed-off-by: Sandeep Paulraj >>> Signed-off-by: Mark A. Greer >>> Signed-off-by: Philby John >>> Signed-off-by: Sudhakar Rajashekhara >> >> Sandeep, >> >> This needs a minor refresh against current Linus tree for the Makefile >> change. >> >> While doing the Makefile addition, it looks like the list is maintained = in >> alphabetical order. =A0Please add davinci in the right order, and feel f= ree to >> add my signoff. > > Signed-of-by lines are only for patches that actually pass through > your hands (ie. you add it yourself when you pick it up and pass it). > It is not appropriate to add a s-o-b line for someone else. > "Acked-by" or "Reviewed-by" should be used instead. Understood. This driver has passed through my hands (and in front of my eyes) in various forms many times in its development, so I figured an s-o-b was appropriate. That being said, for this particular version, and ack is probably more appropriate. Sandeep, after you refresh, please add Acked-by: Kevin Hilman ---------------------------------------------------------------------------= --- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev =