From: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
To: Brian Niebuhr <bniebuhr3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH 1/2 v2] spi: overhaul davinci spi driver to correct multiple errors
Date: Fri, 12 Mar 2010 16:22:44 -0800 [thread overview]
Message-ID: <87k4th2hpn.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1268422520-22642-2-git-send-email-bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org> (Brian Niebuhr's message of "Fri\, 12 Mar 2010 13\:35\:19 -0600")
Brian Niebuhr <bniebuhr3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> This patch is a significant overhaul of the davinci spi controller driver
> that corrects multiple errors:
>
> - Eliminate a race condition that exists for slow SPI devices
> - Fix DMA transfer length error
> - Fix limitations preventing multiple SPI devices on the same controller
>
> Signed-off-by: Brian Niebuhr <bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org>
The verbose description of the issues addressed from PATCH 0/2 should
go here is well so it makes it into the permanent git history.
That being said, I think for the sake of reviewing, you're going to
need to break this up into reviewable pieces, each having a verbose
description of the issues being solved.
There is also a mixture of fixes, enhancements, renames etc. These
should be done as separate patches.
I know that it's more work to break it up like this, but that's the
only way to make a large change like this reviewable by others.
Thanks,
Kevin
next prev parent reply other threads:[~2010-03-13 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 19:35 [PATCH 0/2 v2] overhaul davinci spi driver to fix multiple errors Brian Niebuhr
[not found] ` <1268422520-22642-1-git-send-email-bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org>
2010-03-12 19:35 ` [PATCH 1/2 v2] spi: overhaul davinci spi driver to correct " Brian Niebuhr
[not found] ` <1268422520-22642-2-git-send-email-bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org>
2010-03-12 19:35 ` [PATCH 2/2 v2] spi: modify davinci platform data for updated driver Brian Niebuhr
2010-03-13 0:22 ` Kevin Hilman [this message]
[not found] ` <87k4th2hpn.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-03-15 14:24 ` [PATCH 1/2 v2] spi: overhaul davinci spi driver to correct multiple errors Brian Niebuhr
[not found] ` <A117B9F753B6EB4580D381ED91D0FED00178A905-o2xmcm0DlSXTuRhSVNLHwoz1bQe5IM3EhPhL2mjWHbk@public.gmane.org>
2010-03-15 15:50 ` Kevin Hilman
[not found] ` <87r5nl1t56.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-03-17 14:32 ` Sudhakar Rajashekhara
2010-03-17 14:32 ` Sudhakar Rajashekhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4th2hpn.fsf@deeprootsystems.com \
--to=khilman-1d3hcaltpluheniveurvkkeocmrvltnr@public.gmane.org \
--cc=bniebuhr3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).