Re: [PATCH] Revert "spi: cadence-qspi: Improve spi memory performance"

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Mark,

On 31/03/2025 at 14:24:19 +01, Mark Brown <broonie@kernel.org> wrote:

> On Fri, Mar 28, 2025 at 06:35:00PM +0100, Miquel Raynal wrote:
>
>> the probing of the DMA controller has been fixed, and the performances are
>> back to normal, so we can safely revert this commit.
>
>> This reverts commit 6e6363dd2f1e5b3e42505606ea494572c81dbb64.
>
> This commit doesn't appear to exist, you seem to mean cce2200dacd6 (spi:
> cadence-qspi: Improve spi memory performance), I fixed it up for that.

Crap, must have catch the one from my own local tree, thanks for fixing.

> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.

I'm curious, maybe this is a semi-automated message, but do you have a
specific style for reverts that deviates from git's?

> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

As per the "This reverts commit <sha>" this is also the standard Git way
to indicate a revert, I kept it as-is.

Thanks,
Miquèl