From: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Cc: Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match
Date: Wed, 05 Aug 2015 21:07:25 +0200 [thread overview]
Message-ID: <87lhdplfki.fsf@belgarion.home> (raw)
In-Reply-To: <55C05490.500-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> (Jarkko Nikula's message of "Tue, 04 Aug 2015 08:58:40 +0300")
Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> writes:
> On 08/04/2015 08:52 AM, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
I would have appreciated something in the git commit message, ie :
- a "Fixes" tag maybe
- a comment to describe how it was discovered : code reading, testing, etc ...
> Acked-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
With a better commit message, please have my :
Acked-by: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-05 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 5:52 [PATCH] spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match Axel Lin
[not found] ` <1438667542.8228.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
2015-08-04 5:58 ` Jarkko Nikula
[not found] ` <55C05490.500-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-05 19:07 ` Robert Jarzmik [this message]
2015-08-04 17:48 ` Applied "spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhdplfki.fsf@belgarion.home \
--to=robert.jarzmik-ganu6spqydw@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org \
--cc=haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).