From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Mark Brown <broonie@kernel.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER
Date: Mon, 13 Oct 2025 13:20:38 +0200 [thread overview]
Message-ID: <87o6qbujy1.fsf@kernel.org> (raw)
In-Reply-To: <eb66bb86-328f-4d43-96db-e0a31eb73ee8@sirena.org.uk>
On Mon, Oct 13, 2025 at 11:22, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Oct 09, 2025 at 09:10:38AM +0200, Mattijs Korpershoek wrote:
>> In csqspi_probe(), when cqspi_request_mmap_dma() returns -EPROBE_DEFER,
>> we handle the error by jumping to probe_setup_failed.
>> In that label, we call pm_runtime_disable(), even if we never called
>> pm_runtime_enable() before.
>
> This doesn't apply against current code, please check and resend.
Ah, sorry about that. I based this on master. I confirm it does not
apply on for-6.18.
Will resend shortly.
next prev parent reply other threads:[~2025-10-13 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 7:10 [PATCH v2] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER Mattijs Korpershoek
2025-10-09 7:37 ` Dan Carpenter
2025-10-13 10:22 ` Mark Brown
2025-10-13 11:20 ` Mattijs Korpershoek [this message]
2025-10-15 13:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6qbujy1.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=khairul.anuar.romli@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).