Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Miquel Raynal
	<miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Antoine Tenart
	<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 0/2] Fix issues in Armada-3700 SPI controller driver
Date: Wed, 13 Sep 2017 10:20:38 -0700	[thread overview]
Message-ID: <87o9qeh5w9.fsf@free-electrons.com> (raw)
In-Reply-To: <20170913162139.17598-1-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> (Miquel Raynal's message of "Wed, 13 Sep 2017 18:21:37 +0200")

Hi Miquel and Mark,
 
 On mer., sept. 13 2017, Miquel Raynal <miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> Hello,
>
> This short serie addresses two issues in Armada-3700 SPI controller driver.
>
> Second patch from Zachary Zhang fixes the way padding is introduced in not
> 4-byte aligned SPI transfers (that fails some NAND flash devices). It also
> revealed the issue fixed by the first commit when using quad-SPI. Thus, it
> would be preferable to apply them in that order.
>
> Differences with the first version:
> - Added this cover letter.
> - Fixed the commit titles by using "spi: armada-3700:" prefix.
>
> And sorry for the noise.

These two patches being fixes it would be nice to add the Fixes and
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> flags. Indeed the older version on Linux
should be fixed too.

Miquel could you provide the accurate Fixes: flag ?
(By the way there is also a way to indicate dependency between patches
for stable, see Documentation/process/stable-kernel-rules.rst.)

Mark, could you amend the patches with the flags that will be provided
my Miquel? Thanks, to this the patches will be backported to te stables
branches.

Thanks!

Gregory

>
> Thanks,
> Miquel
>
> Miquel Raynal (1):
>   spi: armada-3700: Fix failing commands with quad-SPI
>
> Zachary Zhang (1):
>   spi: armada-3700: Fix padding when sending not 4-byte aligned data
>
>  drivers/spi/spi-armada-3700.c | 142 ++++++++++++++----------------------------
>  1 file changed, 46 insertions(+), 96 deletions(-)
>
> -- 
> 2.11.0
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-09-13 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 16:21 [PATCH v2 0/2] Fix issues in Armada-3700 SPI controller driver Miquel Raynal
     [not found] ` <20170913162139.17598-1-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-09-13 16:21   ` [PATCH v2 1/2] spi: armada-3700: Fix failing commands with quad-SPI Miquel Raynal
2017-09-13 16:21   ` [PATCH v2 2/2] spi: armada-3700: Fix padding when sending not 4-byte aligned data Miquel Raynal
2017-09-13 17:20   ` Gregory CLEMENT [this message]
     [not found]     ` <87o9qeh5w9.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-09-13 18:12       ` [PATCH v2 0/2] Fix issues in Armada-3700 SPI controller driver Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9qeh5w9.fsf@free-electrons.com \
    --to=gregory.clement-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox