Re: [Uclinux-dist-devel] [PATCH] Clear control bits in drivers/spi/spi_bfin5xx.c as necessary

[Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Fri, Dec 18, 2009 at 02:29, James Getzendanner wrote:
> From: Andy Getzendanner <james.getzendanner@students.olin.edu>
>
> This patch corrects the behavior of bfin_spi_setup() to clear bits LSBF,
> CPHA, and CPOL in the SPI control register when required by the desired
> SPI configuration.

why not always zero out ctl_reg then
    if (chip_info) {
    ...
    } else {
+        chip->ctl_reg = 0;

> The patch also modifies bfin_spi_setup() to
> set/clear the SIZE bit as appropriate.

ok, but this isnt the place to do it.  the size can be changed on a
per-transfer basis.  i have a patch locally to unify the transfer size
logic and i'll include this fix in the process.

> The control bits LSBF, CPHA, and CPOL are set by bfin_spi_setup() when
> appropriate, but the function appears to assume they are clear at entry
> and leaves them untouched when the desired configuration calls for them
> to be clear.  The SIZE bit is never set or cleared.
> bfin_spi_setup() is triggered in response to an ioctl which calls for
> the SPI configuration to be changed, but the settings controlled by
> LSBF, CPHA, and CPOL cannot be changed away from the setting implied by
> the value 1.  Additionally, the word length setting (controlled by SIZE)
> is not set correctly.

this info should be in the changelog, not below the --- ignore marker
-mike

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general