Re: [Uclinux-dist-devel] [PATCH] Clear control bits in drivers/spi/spi_bfin5xx.c as necessary

[Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Fri, Dec 18, 2009 at 08:14, Mike Frysinger wrote:
> On Fri, Dec 18, 2009 at 02:29, James Getzendanner wrote:
>> From: Andy Getzendanner <james.getzendanner@students.olin.edu>
>> The patch also modifies bfin_spi_setup() to
>> set/clear the SIZE bit as appropriate.
>
> ok, but this isnt the place to do it.  the size can be changed on a
> per-transfer basis.  i have a patch locally to unify the transfer size
> logic and i'll include this fix in the process.

i lied, this isnt necessary.  it's already handled in the transfer code.
    cr = (read_CTRL(drv_data) & (~BIT_CTL_TIMOD));
    cr |= (width << 8);
    write_CTRL(drv_data, cr);

where width is CFG_SPI_WORDSIZE16 or CFG_SPI_WORDSIZE8 as dictated by
the transfer.
-mike

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general