From: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
yi.li-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/5] spi: spi_lock_bus and spi_unlock_bus
Date: Wed, 17 Feb 2010 00:04:05 -0500 [thread overview]
Message-ID: <8bd0f97a1002162104u5291da69gbff20837f78c9cdf@mail.gmail.com> (raw)
In-Reply-To: <fa686aa41002162047h4b4c9cdam2133baf3b7d0e27c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Feb 16, 2010 at 23:47, Grant Likely wrote:
> On Tue, Feb 16, 2010 at 9:34 PM, Mike Frysinger wrote:
>> On Tue, Feb 16, 2010 at 22:48, Grant Likely wrote:
>>>> there's nothing Blackfin-specific in the implementation of these
>>>> functions. i think the way we should be handling these is by doing:
>>>> - remove {lock,unlock}_bus functions from spi_master
>>>> - move the {lock,unlock}_bus code from spi_bfin5xx.c to spi.c
>>>> - drop the SPI_BFIN_LOCK Kconfig
>>>
>>> Am I missing something. I cannot find any lock related functions in
>>> the spi code. Is this stuff in mainline?
>>
>> i'm proposing what should be done. there is no locking logic anywhere atm.
>
> Okay, but you're talking about removing functions (lock_bus,
> unlock_bus) and config values (SPI_BFIN_LOCK) which I cannot find
> anywhere in mainline.
they were part of the patchsets that were under discussion
-mike
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
next prev parent reply other threads:[~2010-02-17 5:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 19:44 [PATCH 0/5] spi/mmc_spi: SPI bus locking to use mmc_spi together with other SPI devices Ernst Schwab
[not found] ` <20100216204450.e043eed8.eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
2010-02-16 19:57 ` [PATCH 1/5] spi: spi_lock_bus and spi_unlock_bus Ernst Schwab
[not found] ` <20100216205720.ebe949a1.eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
2010-02-16 20:43 ` Grant Likely
[not found] ` <fa686aa41002161243y6e24e439yff54a28cbe295de3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-16 21:16 ` Ned Forrester
[not found] ` <4B7B0B1C.8050407-/d+BM93fTQY@public.gmane.org>
2010-02-16 23:23 ` Grant Likely
2010-02-17 0:07 ` Mike Frysinger
2010-02-17 0:21 ` Ernst Schwab
2010-02-17 0:40 ` Mike Frysinger
[not found] ` <8bd0f97a1002161607m3c748ccegaffb83c42667287a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 3:48 ` Grant Likely
[not found] ` <fa686aa41002161948o31a48fc9kac263b0ac34f1a8d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 4:34 ` Mike Frysinger
[not found] ` <8bd0f97a1002162034r2d3e397eq12ae0f0df1ae2adb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 4:47 ` Grant Likely
[not found] ` <fa686aa41002162047h4b4c9cdam2133baf3b7d0e27c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 5:04 ` Mike Frysinger [this message]
[not found] ` <8bd0f97a1002162104u5291da69gbff20837f78c9cdf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 5:08 ` Grant Likely
2010-02-17 4:37 ` Grant Likely
2010-02-17 0:16 ` Ernst Schwab
2010-02-17 4:32 ` Grant Likely
2010-02-17 7:35 ` Ernst Schwab
2010-02-17 13:30 ` Grant Likely
[not found] ` <fa686aa41002170530i2ae007c2ia4f2ad185dfd2713-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 14:12 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a1002162104u5291da69gbff20837f78c9cdf@mail.gmail.com \
--to=vapier.adi-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=yi.li-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).