Re: [PATCH v3 2/7] spi: qcom-qspi: Fix incomplete error handling in runtime PM

Viken Dadhaniya
2026-04-24T16:52:26Z

On 4/20/2026 9:59 PM, Mark Brown wrote:
> On Mon, Apr 20, 2026 at 11:42:49AM +0530, Viken Dadhaniya wrote:
>> The runtime PM functions had incomplete error handling that could leave the
>> system in an inconsistent state. If any operation failed midway through
>> suspend or resume, some resources would be left in the wrong state while
>> others were already changed, leading to potential clock/power imbalances.
>
>> +err_select_default_state:
>> + pinctrl_pm_select_default_state(dev);
>> +err_enable_icc:
>> + icc_enable(ctrl->icc_path_cpu_to_qspi);
>> +err_enable_clk:
>> + clk_bulk_prepare_enable(QSPI_NUM_CLKS, ctrl->clks);
>
> clk_bulk_prepare_enable() is marked __must_check.

I’ll update it in the next patch set.