Re: [PATCH v3 3/7] spi: qcom-qspi: Add interconnect support for memory path

Konrad Dybcio
2026-04-23T11:20:08Z

On 4/23/26 6:41 AM, Viken Dadhaniya wrote:
>
>
> On 4/20/2026 10:14 PM, Mark Brown wrote:
>> On Mon, Apr 20, 2026 at 11:42:50AM +0530, Viken Dadhaniya wrote:
>>> The QSPI controller has two interconnect paths:
>>> 1. qspi-config: CPU to QSPI controller for register access
>>> 2. qspi-memory: QSPI controller to memory for DMA operations
>>
>>> @@ -729,6 +737,11 @@ static int qcom_qspi_probe(struct platform_device *pdev)
>>> return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_cpu_to_qspi),
>>> "Failed to get cpu path\n");
>>>
>>> + ctrl->icc_path_mem = devm_of_icc_get(dev, "qspi-memory");
>>> + if (IS_ERR(ctrl->icc_path_mem))
>>> + return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_mem),
>>> + "Failed to get memory path\n");
>>> +
>>
>> Does this handle missing qspi-memory properly? It's not conditional on
>> the compatible so it'll run even for existing devices.
>
> All existing device trees have been updated to include this path,
> so there won't be any probe failures for existing devices.

The problem is, not all users of the new kernel also update the device
trees

Konrad