Re: [PATCH v8 15/15] arm: dts: airoha: en7523: add SNAND node

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/10/2025 21:20, Mikhail Kshevetskiy wrote:
> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> ---
>  arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
> index b523a868c4ad..a13dc6e77d08 100644
> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>  			#interrupt-cells = <1>;
>  		};
>  	};
> +
> +	spi_ctrl: spi_controller@1fa10000 {
> +		compatible = "airoha,en7581-snand";

Wrong compatible, this is 7523. You already got comment to make them
compatible. Look at writing bindings, or example schema or my last talk
for beginners from OSSEU.


> +		reg = <0x1fa10000 0x140>,
> +		      <0x1fa11000 0x160>;
> +
> +		clocks = <&scu EN7523_CLK_SPI>;
> +		clock-names = "spi";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		nand: nand@0 {
> +			compatible = "spi-nand";
> +			reg = <0>;
> +			spi-max-frequency = <50000000>;
> +			spi-tx-bus-width = <1>;
> +			spi-rx-bus-width = <2>;
> +		};
> +	};
> +

Don't add stray blank lines.

>  };


Best regards,
Krzysztof