From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Lechner <dlechner@baylibre.com>, Mark Brown <broonie@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property
Date: Mon, 8 Jan 2024 09:40:31 +0100 [thread overview]
Message-ID: <99437454-4e58-4ce2-a0b8-f2d7e3fd2c2f@linaro.org> (raw)
In-Reply-To: <CAMknhBE7eUMzcD0bdymrhL2Lw3FubB3aHDWmJFD7YnaGNYmQ9w@mail.gmail.com>
On 08/01/2024 00:02, David Lechner wrote:
> On Sun, Jan 7, 2024 at 3:27 PM Mark Brown <broonie@kernel.org> wrote:
>>
>> On Sun, Jan 07, 2024 at 04:43:56PM +0000, Jonathan Cameron wrote:
>>> David Lechner <dlechner@baylibre.com> wrote:
>>
>>>> This adds a new spi-rx-bus-channels property to the generic spi
>>>> peripheral property bindings. This property is used to describe
>>>> devices that have parallel data output channels.
>>
>>>> This property is different from spi-rx-bus-width in that the latter
>>>> means that we are reading multiple bits of a single word at one time
>>>> while the former means that we are reading single bits of multiple words
>>>> at the same time.
>>
>>> Mark, could you take a look at this SPI binding change when you have time?
>>
>> Please submit patches using subject lines reflecting the style for the
>> subsystem, this makes it easier for people to identify relevant patches.
>> Look at what existing commits in the area you're changing are doing and
>> make sure your subject lines visually resemble what they're doing.
>> There's no need to resubmit to fix this alone.
>
> Are you saying that `spi: dt-bindings:` should be preferred over
> `dt-bindings: spi:`?
>
> I thought I was doing it right since I was following the guidelines of
> [1] which says:
>
>> The preferred subject prefix for binding patches is:
>> "dt-bindings: <binding dir>: ..."
>
> [1]: https://www.kernel.org/doc/html//v6.7/devicetree/bindings/submitting-patches.html
There are exceptions. I documented them now:
https://lore.kernel.org/linux-devicetree/20240108083750.16350-2-krzysztof.kozlowski@linaro.org/T/#u
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-08 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 10:32 [PATCH v3 0/3] iio: adc: add new ad7380 driver David Lechner
2023-12-15 10:32 ` [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property David Lechner
2023-12-15 19:58 ` Rob Herring
2024-01-07 16:43 ` Jonathan Cameron
2024-01-07 21:26 ` Mark Brown
2024-01-07 23:02 ` David Lechner
2024-01-08 8:40 ` Krzysztof Kozlowski [this message]
2024-01-08 16:39 ` Mark Brown
2024-01-08 17:15 ` David Lechner
2024-01-10 9:09 ` Jonathan Cameron
2023-12-15 10:32 ` [PATCH v3 2/3] dt-bindings: iio: adc: Add binding for AD7380 ADCs David Lechner
2023-12-15 10:32 ` [PATCH v3 3/3] iio: adc: ad7380: new driver " David Lechner
2023-12-15 16:53 ` Christophe JAILLET
2023-12-15 17:31 ` David Lechner
2023-12-15 17:34 ` David Lechner
2023-12-17 14:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99437454-4e58-4ce2-a0b8-f2d7e3fd2c2f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).