linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-spi@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 18/33] spi: cadence-quadspi: Don't emit error message on allocation error
Date: Mon, 15 Jan 2024 21:13:04 +0100	[thread overview]
Message-ID: <9ef43fafa33c50e3ece45b065bf860419fdf3523.1705348270.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1705348269.git.u.kleine-koenig@pengutronix.de>

Drivers are not supposed to emit an error message when a memory
allocation fails, as the kernel is very loud in this case already
anyhow.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/spi/spi-cadence-quadspi.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index f94e0d370d46..eb6cc861b00b 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1712,10 +1712,9 @@ static int cqspi_probe(struct platform_device *pdev)
 	int irq;
 
 	host = devm_spi_alloc_host(&pdev->dev, sizeof(*cqspi));
-	if (!host) {
-		dev_err(&pdev->dev, "devm_spi_alloc_host failed\n");
+	if (!host)
 		return -ENOMEM;
-	}
+
 	host->mode_bits = SPI_RX_QUAD | SPI_RX_DUAL;
 	host->mem_ops = &cqspi_mem_ops;
 	host->mem_caps = &cqspi_mem_caps;
-- 
2.43.0


  parent reply	other threads:[~2024-01-15 20:21 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 20:12 [PATCH 00/33] spi: get rid of some legacy macros Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 01/33] fpga: ice40-spi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-20 15:29   ` Xu Yilun
2024-01-15 20:12 ` [PATCH 02/33] ieee802154: ca8210: " Uwe Kleine-König
2024-01-16 20:06   ` Simon Horman
2024-01-17 12:19   ` Stefan Schmidt
2024-01-15 20:12 ` [PATCH 03/33] iio: adc: ad_sigma_delta: " Uwe Kleine-König
2024-01-16  7:44   ` Nuno Sá
2024-01-21 16:27     ` Jonathan Cameron
2024-01-15 20:12 ` [PATCH 04/33] Input: pxspad - follow " Uwe Kleine-König
2024-01-16 19:14   ` Dmitry Torokhov
2024-01-15 20:12 ` [PATCH 05/33] Input: synaptics-rmi4 " Uwe Kleine-König
2024-01-16 19:14   ` Dmitry Torokhov
2024-01-15 20:12 ` [PATCH 06/33] media: mgb4: Follow " Uwe Kleine-König
2024-01-16 10:17   ` Martin Tůma
2024-01-15 20:12 ` [PATCH 07/33] media: netup_unidvb: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 08/33] media: usb/msi2500: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 09/33] media: v4l2-subdev: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 10/33] misc: gehc-achc: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 11/33] mmc: mmc_spi: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 12/33] mtd: dataflash: " Uwe Kleine-König
2024-01-15 20:12 ` [PATCH 13/33] mtd: rawnand: fsl_elbc: Let .probe retry if local bus is missing Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 14/33] net: ks8851: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-16 20:05   ` Simon Horman
2024-01-15 20:13 ` [PATCH 15/33] net: vertexcom: mse102x: " Uwe Kleine-König
2024-01-16 20:05   ` Simon Horman
2024-01-15 20:13 ` [PATCH 16/33] platform/chrome: cros_ec_spi: " Uwe Kleine-König
2024-01-18  3:49   ` Tzung-Bi Shih
2024-01-15 20:13 ` [PATCH 17/33] spi: bitbang: " Uwe Kleine-König
2024-01-16  8:33   ` Geert Uytterhoeven
2024-01-16 12:47     ` Uwe Kleine-König
2024-01-19  7:11   ` kernel test robot
2024-01-15 20:13 ` Uwe Kleine-König [this message]
2024-01-15 20:13 ` [PATCH 19/33] spi: cadence-quadspi: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 20/33] spi: cavium: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 21/33] spi: geni-qcom: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 22/33] spi: loopback-test: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 23/33] spi: slave-mt27xx: " Uwe Kleine-König
2024-01-16 15:41   ` Mark Brown
2024-01-15 20:13 ` [PATCH 24/33] spi: spidev: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 25/33] staging: fbtft: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 26/33] staging: greybus: spi: " Uwe Kleine-König
2024-01-16  5:38   ` Viresh Kumar
2024-01-15 20:13 ` [PATCH 27/33] tpm_tis_spi: " Uwe Kleine-König
2024-01-19 21:29   ` Jarkko Sakkinen
2024-01-15 20:13 ` [PATCH 28/33] usb: gadget: max3420_udc: " Uwe Kleine-König
2024-01-16  7:25   ` Herve Codina
2024-01-15 20:13 ` [PATCH 29/33] video: fbdev: mmp: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 30/33] wifi: libertas: " Uwe Kleine-König
2024-01-18  9:26   ` Kalle Valo
2024-01-15 20:13 ` [PATCH 31/33] spi: fsl-lib: " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 32/33] spi: Drop compat layer from renaming " Uwe Kleine-König
2024-01-15 20:13 ` [PATCH 33/33] Documentation: spi: Update documentation for " Uwe Kleine-König
2024-01-16 14:40 ` [PATCH 00/33] spi: get rid of some legacy macros Mark Brown
2024-01-16 15:18   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ef43fafa33c50e3ece45b065bf860419fdf3523.1705348270.git.u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kernel@pengutronix.de \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).