Request for SPI testing

Request for SPI testing

[Grant Likely]

I've pushed out Ernst's spi bus locking API patches to the following
branch.  Before I push them into linux-next, I'd like to get some
testing.  Can I have some volunteers please to pull this branch and
give it a spin?  Bonus points for people who have mmc cards
multiplexed with other devices on their SPI bus.

Cheers,
g.

The following changes since commit 5904b3b81d25166e5e39b9727645bb47937618e3:
  Linus Torvalds (1):
        Merge branch 'perf-fixes-for-linus' of
git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

  git://git.secretlab.ca/git/linux-2.6 spi/test

Cory Maccarrone (1):
      SPI100k: Fix 8-bit and RX-only transfers

Ernst Schwab (2):
      spi/mmc_spi: SPI bus locking API, using mutex
      spi/mmc_spi: mmc_spi adaptations for SPI bus locking API

 drivers/mmc/host/mmc_spi.c  |   59 ++---------
 drivers/spi/omap_spi_100k.c |   23 +++--
 drivers/spi/spi.c           |  225 ++++++++++++++++++++++++++++++++++++-------
 include/linux/spi/spi.h     |   12 +++
 4 files changed, 227 insertions(+), 92 deletions(-)

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: Request for SPI testing

[Matt Fleming]

On Tue, Jun 29, 2010 at 09:30:34PM -0600, Grant Likely wrote:
> I've pushed out Ernst's spi bus locking API patches to the following
> branch.  Before I push them into linux-next, I'd like to get some
> testing.  Can I have some volunteers please to pull this branch and
> give it a spin?  Bonus points for people who have mmc cards
> multiplexed with other devices on their SPI bus.

I put these patches through some light testing by reading data from a
flash device and writing it to an mmc card, both over SPI. They seem
to hold up fine, but I can certainly try some other things if you have
anything specific in mind.

Re: Request for SPI testing

[Ernst Schwab]

Hi Grant,

> I've pushed out Ernst's spi bus locking API patches to the following
> branch.  Before I push them into linux-next, I'd like to get some
> testing.  Can I have some volunteers please to pull this branch and
> give it a spin?  Bonus points for people who have mmc cards
> multiplexed with other devices on their SPI bus.

Thanks for bringing up this topic.

We are working with these two patches (except the 
spin_lock_irqsave modification and the 'bool' datatype 
for bus_lock_flag) for several months on our system 
(powerpc, MPC8314, kernel 2.6.32.7 and 2.6.32.14) 
that makes heavy use of several SPI devices: 9 x EEPROM, 
3 x dataflash, MMC and 2 x MDIO-pseudo-SPI (with a special 
SPI-to-MDIO bus driver).
The MMC is used rarely, but the rest is essential for 
system operation. Until now, we observed no problems,
even when copying EEPROM data to MMC. So you may add
my 'tested-by'.

Best regards
Ernst

Re: Request for SPI testing

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]

On Tue, 29 Jun 2010 21:30:34 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:

> I've pushed out Ernst's spi bus locking API patches to the following
> branch.  Before I push them into linux-next, I'd like to get some
> testing.  Can I have some volunteers please to pull this branch and
> give it a spin?  Bonus points for people who have mmc cards
> multiplexed with other devices on their SPI bus.
>

From a quick test it works for me too, I have both the MMC and the PMIC
(battery, regulators) attached to spi, this is Motorola A910 phone
(pxa27x). Just FYI I applied the patches to 2.6.34 and tested with this
kernel, without the patches I cannot make mmc_spi work reliably (lots
of I/O errors, due to conflict with the PMIC) with these patches I can
finally use the MMC card.

Thanks a lot,
   Antonio

> Cheers,
> g.
> 
> The following changes since commit 5904b3b81d25166e5e39b9727645bb47937618e3:
>   Linus Torvalds (1):
>         Merge branch 'perf-fixes-for-linus' of
> git://git.kernel.org/.../tip/linux-2.6-tip
> 
> are available in the git repository at:
> 
>   git://git.secretlab.ca/git/linux-2.6 spi/test
> 
> Cory Maccarrone (1):
>       SPI100k: Fix 8-bit and RX-only transfers
> 
> Ernst Schwab (2):
>       spi/mmc_spi: SPI bus locking API, using mutex
>       spi/mmc_spi: mmc_spi adaptations for SPI bus locking API
> 
>  drivers/mmc/host/mmc_spi.c  |   59 ++---------
>  drivers/spi/omap_spi_100k.c |   23 +++--
>  drivers/spi/spi.c           |  225 ++++++++++++++++++++++++++++++++++++-------
>  include/linux/spi/spi.h     |   12 +++
>  4 files changed, 227 insertions(+), 92 deletions(-)
> 
> -- 
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
> 


-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: Request for SPI testing

[Grant Likely]

On Sat, Jul 3, 2010 at 11:05 AM, Antonio Ospite
<ospite@studenti.unina.it> wrote:
> On Tue, 29 Jun 2010 21:30:34 -0600
> Grant Likely <grant.likely@secretlab.ca> wrote:
>
>> I've pushed out Ernst's spi bus locking API patches to the following
>> branch.  Before I push them into linux-next, I'd like to get some
>> testing.  Can I have some volunteers please to pull this branch and
>> give it a spin?  Bonus points for people who have mmc cards
>> multiplexed with other devices on their SPI bus.
>>
>
> From a quick test it works for me too, I have both the MMC and the PMIC
> (battery, regulators) attached to spi, this is Motorola A910 phone
> (pxa27x). Just FYI I applied the patches to 2.6.34 and tested with this
> kernel, without the patches I cannot make mmc_spi work reliably (lots
> of I/O errors, due to conflict with the PMIC) with these patches I can
> finally use the MMC card.
>
> Thanks a lot,
>   Antonio

Thanks everyone who tested.  I've pushed this out for linux-next
inclusion (next-spi branch)

g.