[PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Govindraj.R]

Changes invloves:
----------------
1) Addition of hwmod data for omap2/3/4.
1) McSPI driver hwmod adaptation with cleanup of base address
   macros and using omap-device API's.
2) Runtime Conversion of McSPI driver

Changes from v1:
---------------
1) Fixing patch 5/5 comments for hwmod+runtime
   Split the patch 5/5 to hwmod adaptation
   and then runtime conversion
   http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html

Testing Updates:
----------------
Was tested using data transfer test module available at:
http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
utils/mcspi_modules/omap_mcspi_datatest.c;
h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3

System wide suspend and ret/off counts observation,
ensured that no behavioral difference with and without
this patch series.

Benoit Cousson (1):
  OMAP4: hwmod data: Add McSPI

Charulatha V (5):
  OMAP2420: hwmod data: Add McSPI
  OMAP2430: hwmod data: Add McSPI
  OMAP3: hwmod data: Add McSPI
  OMAP3: clocks: Update clock domain name for mcspi fck
  OMAP: devices: Modify McSPI device to adapt to hwmod framework

Govindraj.R (1):
  OMAP: runtime: McSPI driver runtime conversion

 arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
 arch/arm/mach-omap2/devices.c              |  189 ++++---------------
 arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
 arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
 arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
 drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
 8 files changed, 1051 insertions(+), 300 deletions(-)

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Govindraj]

On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R <govindraj.raja@ti.com> wrote:
> Changes invloves:
> ----------------
> 1) Addition of hwmod data for omap2/3/4.
> 1) McSPI driver hwmod adaptation with cleanup of base address
>   macros and using omap-device API's.
> 2) Runtime Conversion of McSPI driver


Any comments or feedback on this patch series?

If no comments I hope patch series can be merged
through LO tree with a ack from Grant on
patch 6/6 and patch 7/7.

Benoit,
I may need you comments or ack on patch 1/[1-4]

Patch 1/5 will be posted out separately as per Paul's
comments:
http://ns3.spinics.net/lists/linux-omap/msg41219.html

--
Thanks,
Govindraj.R

>
> Changes from v1:
> ---------------
> 1) Fixing patch 5/5 comments for hwmod+runtime
>   Split the patch 5/5 to hwmod adaptation
>   and then runtime conversion
>   http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>
> Testing Updates:
> ----------------
> Was tested using data transfer test module available at:
> http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
> utils/mcspi_modules/omap_mcspi_datatest.c;
> h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
> hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>
> System wide suspend and ret/off counts observation,
> ensured that no behavioral difference with and without
> this patch series.
>
> Benoit Cousson (1):
>  OMAP4: hwmod data: Add McSPI
>
> Charulatha V (5):
>  OMAP2420: hwmod data: Add McSPI
>  OMAP2430: hwmod data: Add McSPI
>  OMAP3: hwmod data: Add McSPI
>  OMAP3: clocks: Update clock domain name for mcspi fck
>  OMAP: devices: Modify McSPI device to adapt to hwmod framework
>
> Govindraj.R (1):
>  OMAP: runtime: McSPI driver runtime conversion
>
>  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
>  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
>  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
>  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
>  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
>  8 files changed, 1051 insertions(+), 300 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Kevin Hilman]

"Govindraj.R" <govindraj.raja@ti.com> writes:

> Changes invloves:
> ----------------
> 1) Addition of hwmod data for omap2/3/4.
> 1) McSPI driver hwmod adaptation with cleanup of base address
>    macros and using omap-device API's.
> 2) Runtime Conversion of McSPI driver
>
> Changes from v1:
> ---------------
> 1) Fixing patch 5/5 comments for hwmod+runtime
>    Split the patch 5/5 to hwmod adaptation
>    and then runtime conversion
>    http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>
> Testing Updates:
> ----------------
> Was tested using data transfer test module available at:
> http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
> utils/mcspi_modules/omap_mcspi_datatest.c;
> h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
> hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3

Can you summarize what this test does?  

On what platforms was this tested?  

How was it tested for OMAP1 and OMAP2?

Kevin

> System wide suspend and ret/off counts observation,
> ensured that no behavioral difference with and without
> this patch series.
>
> Benoit Cousson (1):
>   OMAP4: hwmod data: Add McSPI
>
> Charulatha V (5):
>   OMAP2420: hwmod data: Add McSPI
>   OMAP2430: hwmod data: Add McSPI
>   OMAP3: hwmod data: Add McSPI
>   OMAP3: clocks: Update clock domain name for mcspi fck
>   OMAP: devices: Modify McSPI device to adapt to hwmod framework
>
> Govindraj.R (1):
>   OMAP: runtime: McSPI driver runtime conversion
>
>  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
>  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
>  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
>  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
>  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
>  8 files changed, 1051 insertions(+), 300 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Raja, Govindraj]

Hi Kevin,


On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>wrote:

> "Govindraj.R" <govindraj.raja-l0cyMroinI0@public.gmane.org> writes:
>
> > Changes invloves:
> > ----------------
> > 1) Addition of hwmod data for omap2/3/4.
> > 1) McSPI driver hwmod adaptation with cleanup of base address
> >    macros and using omap-device API's.
> > 2) Runtime Conversion of McSPI driver
> >
> > Changes from v1:
> > ---------------
> > 1) Fixing patch 5/5 comments for hwmod+runtime
> >    Split the patch 5/5 to hwmod adaptation
> >    and then runtime conversion
> >    http://www.mail-archive.com/linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg33387.html
> >
> > Testing Updates:
> > ----------------
> > Was tested using data transfer test module available at:
> >
> http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
> > utils/mcspi_modules/omap_mcspi_datatest.c;
> > h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
> > hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>
> Can you summarize what this test does?
>
> On what platforms was this tested?
>
> How was it tested for OMAP1 and OMAP2?
>


Using the above mentioned test module we had done some
data transfer tests.
Platforms used used where :
1) OMAP2430 SDP.
2) OMAP3 (ZOOM boards zoom2/3).
3) OMAP4430 SDP [ Here even basic Ethernet functionality was checked which
is over SPI interface]
We boot tested on 2420/n800.

Coming to omap1,

This driver[omap2_mcspi.c] is applicable only from omap2_plus
for omap1 omap_uwire.c is the spi driver file.

Looking into the driver/spi/Kconfig and Makefile:

<KCONFIG SNIP>

config SPI_OMAP_UWIRE
        tristate "OMAP1 MicroWire"
        depends on ARCH_OMAP1

config SPI_OMAP24XX
        tristate "McSPI driver for OMAP"
        depends on ARCH_OMAP2PLUS

<MAKEFILE SNIP>

obj-$(CONFIG_SPI_OMAP_UWIRE)            += omap_uwire.o
obj-$(CONFIG_SPI_OMAP24XX)              += omap2_mcspi.o


---
Thanks,
Govindraj.R



>
> Kevin
>
> > System wide suspend and ret/off counts observation,
> > ensured that no behavioral difference with and without
> > this patch series.
> >
> > Benoit Cousson (1):
> >   OMAP4: hwmod data: Add McSPI
> >
> > Charulatha V (5):
> >   OMAP2420: hwmod data: Add McSPI
> >   OMAP2430: hwmod data: Add McSPI
> >   OMAP3: hwmod data: Add McSPI
> >   OMAP3: clocks: Update clock domain name for mcspi fck
> >   OMAP: devices: Modify McSPI device to adapt to hwmod framework
> >
> > Govindraj.R (1):
> >   OMAP: runtime: McSPI driver runtime conversion
> >
> >  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
> >  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
> >  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280
> ++++++++++++++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267
> ++++++++++++++++++++++++++
> >  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
> >  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
> >  8 files changed, 1051 insertions(+), 300 deletions(-)
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Kevin Hilman]

Hi Govindraj,

"Raja, Govindraj" <govindraj.raja@ti.com> writes:

> On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman <khilman@deeprootsystems.com>
> wrote:
>
>     "Govindraj.R" <govindraj.raja@ti.com> writes:
>
>     > Changes invloves:
>     > ----------------
>     > 1) Addition of hwmod data for omap2/3/4.
>     > 1) McSPI driver hwmod adaptation with cleanup of base address
>     >    macros and using omap-device API's.
>     > 2) Runtime Conversion of McSPI driver
>     >
>     > Changes from v1:
>     > ---------------
>     > 1) Fixing patch 5/5 comments for hwmod+runtime
>     >    Split the patch 5/5 to hwmod adaptation
>     >    and then runtime conversion
>     >    http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>     >
>     > Testing Updates:
>     > ----------------
>     > Was tested using data transfer test module available at:
>     > http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/
>     test_code/
>     > utils/mcspi_modules/omap_mcspi_datatest.c;
>     > h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
>     > hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>
>     Can you summarize what this test does?
>
>     On what platforms was this tested?
>
>     How was it tested for OMAP1 and OMAP2?
>
>
>
> Using the above mentioned test module we had done some
> data transfer tests.
> Platforms used used where :
> 1) OMAP2430 SDP.
> 2) OMAP3 (ZOOM boards zoom2/3).
> 3) OMAP4430 SDP [ Here even basic Ethernet functionality was checked which is
> over SPI interface]

Can you describe a little more about the testing please?  What exactly
does the data transfer test do?  Is it a loopback test?  Does it use
on-board SPI peripherals?  If so, which ones, etc.

> We boot tested on 2420/n800.
>
> Coming to omap1,
>
> This driver[omap2_mcspi.c] is applicable only from omap2_plus
> for omap1 omap_uwire.c is the spi driver file.

OK, thanks for clarification.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Govindraj]

On Thu, Dec 16, 2010 at 11:47 PM, Kevin Hilman
<khilman@deeprootsystems.com> wrote:
> Hi Govindraj,
>
> "Raja, Govindraj" <govindraj.raja@ti.com> writes:
>
>> On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman <khilman@deeprootsystems.com>
>> wrote:
>>
>>     "Govindraj.R" <govindraj.raja@ti.com> writes:
>>
>>     > Changes invloves:
>>     > ----------------
>>     > 1) Addition of hwmod data for omap2/3/4.
>>     > 1) McSPI driver hwmod adaptation with cleanup of base address
>>     >    macros and using omap-device API's.
>>     > 2) Runtime Conversion of McSPI driver
>>     >
>>     > Changes from v1:
>>     > ---------------
>>     > 1) Fixing patch 5/5 comments for hwmod+runtime
>>     >    Split the patch 5/5 to hwmod adaptation
>>     >    and then runtime conversion
>>     >    http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>>     >
>>     > Testing Updates:
>>     > ----------------
>>     > Was tested using data transfer test module available at:
>>     > http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/
>>     test_code/
>>     > utils/mcspi_modules/omap_mcspi_datatest.c;
>>     > h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
>>     > hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>>
>>     Can you summarize what this test does?
>>
>>     On what platforms was this tested?
>>
>>     How was it tested for OMAP1 and OMAP2?
>>
>>
>>
>> Using the above mentioned test module we had done some
>> data transfer tests.
>> Platforms used used where :
>> 1) OMAP2430 SDP.
>> 2) OMAP3 (ZOOM boards zoom2/3).
>> 3) OMAP4430 SDP [ Here even basic Ethernet functionality was checked which is
>> over SPI interface]
>
> Can you describe a little more about the testing please?  What exactly
> does the data transfer test do?  Is it a loopback test?  Does it use
> on-board SPI peripherals?  If so, which ones, etc.
>

Yes its an loopback test based on SPI interface available from
development board expansion connector.

MISO <---> MOSI [Loopback test]

So basically looking into the Board schematics we decide
which SPI interface is available on the board expansion connector
and use SPI interface available.

On zoom boards SPI3 was available on expansion connector
and same was used. On 4430SDP SPI2 interface was used.
On 2430SDP SPI2.

Also for testing, spi_board_info was populated in board file
and spi_register_board_info was done, here bus info was populated
based on spi bus available on the board. In spi_board_info structure
we initialize spi_bus and name as spitst and speed and chip-select
later once test module is loaded word-length, speed etc is modified
from proc interface available from the test module and data test
is done.

--
Thanks,
Govindraj.R


>> We boot tested on 2420/n800.
>>
>> Coming to omap1,
>>
>> This driver[omap2_mcspi.c] is applicable only from omap2_plus
>> for omap1 omap_uwire.c is the spi driver file.
>
> OK, thanks for clarification.
>
> Kevin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Govindraj]

Hi Kevin,

On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman
<khilman@deeprootsystems.com> wrote:
> "Govindraj.R" <govindraj.raja@ti.com> writes:
>
>> Changes invloves:
>> ----------------
>> 1) Addition of hwmod data for omap2/3/4.
>> 1) McSPI driver hwmod adaptation with cleanup of base address
>>    macros and using omap-device API's.
>> 2) Runtime Conversion of McSPI driver
>>
>> Changes from v1:
>> ---------------
>> 1) Fixing patch 5/5 comments for hwmod+runtime
>>    Split the patch 5/5 to hwmod adaptation
>>    and then runtime conversion
>>    http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>>
>> Testing Updates:
>> ----------------
>> Was tested using data transfer test module available at:
>> http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
>> utils/mcspi_modules/omap_mcspi_datatest.c;
>> h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
>> hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>
> Can you summarize what this test does?
>
> On what platforms was this tested?
>
> How was it tested for OMAP1 and OMAP2?


Using the above mentioned test module we had done some
data transfer tests.
Platforms used where :
1) OMAP2430 SDP.
2) OMAP3 (ZOOM boards zoom2/3).
3) OMAP4430 SDP [ Here even basic Ethernet functionality was checked
which is over SPI interface]
We boot tested on 2420/n800.

Coming to omap1,

This driver[omap2_mcspi.c] is applicable only from omap2_plus
for omap1 omap_uwire.c is the spi driver file.

Looking into the driver/spi/Kconfig and Makefile:

<KCONFIG SNIP>

config SPI_OMAP_UWIRE
        tristate "OMAP1 MicroWire"
        depends on ARCH_OMAP1

config SPI_OMAP24XX
        tristate "McSPI driver for OMAP"
        depends on ARCH_OMAP2PLUS

<MAKEFILE SNIP>

obj-$(CONFIG_SPI_OMAP_UWIRE)            += omap_uwire.o
obj-$(CONFIG_SPI_OMAP24XX)              += omap2_mcspi.o

---
Thanks,
Govindraj.R

>
> Kevin
>
>> System wide suspend and ret/off counts observation,
>> ensured that no behavioral difference with and without
>> this patch series.
>>
>> Benoit Cousson (1):
>>   OMAP4: hwmod data: Add McSPI
>>
>> Charulatha V (5):
>>   OMAP2420: hwmod data: Add McSPI
>>   OMAP2430: hwmod data: Add McSPI
>>   OMAP3: hwmod data: Add McSPI
>>   OMAP3: clocks: Update clock domain name for mcspi fck
>>   OMAP: devices: Modify McSPI device to adapt to hwmod framework
>>
>> Govindraj.R (1):
>>   OMAP: runtime: McSPI driver runtime conversion
>>
>>  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
>>  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
>>  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
>>  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
>>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
>>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
>>  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
>>  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
>>  8 files changed, 1051 insertions(+), 300 deletions(-)
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Govindraj]

Hi Grant,


On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R <govindraj.raja@ti.com> wrote:
> Changes invloves:
> ----------------
> 1) Addition of hwmod data for omap2/3/4.
> 1) McSPI driver hwmod adaptation with cleanup of base address
>   macros and using omap-device API's.
> 2) Runtime Conversion of McSPI driver


Any comments on this patch series?
I need your review comments or ack on
patch 6/6 and patch 7/7.

I hope this patch series can be merged with LO
tree with your ack.

--
Thanks
Govindraj.R


>
> Changes from v1:
> ---------------
> 1) Fixing patch 5/5 comments for hwmod+runtime
>   Split the patch 5/5 to hwmod adaptation
>   and then runtime conversion
>   http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
>
> Testing Updates:
> ----------------
> Was tested using data transfer test module available at:
> http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
> utils/mcspi_modules/omap_mcspi_datatest.c;
> h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
> hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
>
> System wide suspend and ret/off counts observation,
> ensured that no behavioral difference with and without
> this patch series.
>
> Benoit Cousson (1):
>  OMAP4: hwmod data: Add McSPI
>
> Charulatha V (5):
>  OMAP2420: hwmod data: Add McSPI
>  OMAP2430: hwmod data: Add McSPI
>  OMAP3: hwmod data: Add McSPI
>  OMAP3: clocks: Update clock domain name for mcspi fck
>  OMAP: devices: Modify McSPI device to adapt to hwmod framework
>
> Govindraj.R (1):
>  OMAP: runtime: McSPI driver runtime conversion
>
>  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
>  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
>  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
>  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
>  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
>  8 files changed, 1051 insertions(+), 300 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
---
Regards,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

[Grant Likely]

On Wed, Dec 29, 2010 at 12:57:35PM +0530, Govindraj wrote:
> Hi Grant,
> 
> 
> On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R <govindraj.raja@ti.com> wrote:
> > Changes invloves:
> > ----------------
> > 1) Addition of hwmod data for omap2/3/4.
> > 1) McSPI driver hwmod adaptation with cleanup of base address
> >   macros and using omap-device API's.
> > 2) Runtime Conversion of McSPI driver
> 
> 
> Any comments on this patch series?
> I need your review comments or ack on
> patch 6/6 and patch 7/7.
> 
> I hope this patch series can be merged with LO
> tree with your ack.

I the process of going through my backlog at the moment.  I should be
able to get to it tomorrow.

g.

> 
> --
> Thanks
> Govindraj.R
> 
> 
> >
> > Changes from v1:
> > ---------------
> > 1) Fixing patch 5/5 comments for hwmod+runtime
> >   Split the patch 5/5 to hwmod adaptation
> >   and then runtime conversion
> >   http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html
> >
> > Testing Updates:
> > ----------------
> > Was tested using data transfer test module available at:
> > http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/
> > utils/mcspi_modules/omap_mcspi_datatest.c;
> > h=e42ec10c5c844abdde6a7175a268b379fbbdb655;
> > hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3
> >
> > System wide suspend and ret/off counts observation,
> > ensured that no behavioral difference with and without
> > this patch series.
> >
> > Benoit Cousson (1):
> >  OMAP4: hwmod data: Add McSPI
> >
> > Charulatha V (5):
> >  OMAP2420: hwmod data: Add McSPI
> >  OMAP2430: hwmod data: Add McSPI
> >  OMAP3: hwmod data: Add McSPI
> >  OMAP3: clocks: Update clock domain name for mcspi fck
> >  OMAP: devices: Modify McSPI device to adapt to hwmod framework
> >
> > Govindraj.R (1):
> >  OMAP: runtime: McSPI driver runtime conversion
> >
> >  arch/arm/mach-omap2/clock3xxx_data.c       |    4 +
> >  arch/arm/mach-omap2/devices.c              |  189 ++++---------------
> >  arch/arm/mach-omap2/omap_hwmod_2420_data.c |  156 ++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_2430_data.c |  219 ++++++++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  280 ++++++++++++++++++++++++++++
> >  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  267 ++++++++++++++++++++++++++
> >  arch/arm/plat-omap/include/plat/mcspi.h    |   11 +
> >  drivers/spi/omap2_mcspi.c                  |  225 +++++++---------------
> >  8 files changed, 1051 insertions(+), 300 deletions(-)
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> 
> 
> -- 
> ---
> Regards,
> Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html