From: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
To: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
Cc: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 23:41:03 +0200 [thread overview]
Message-ID: <AANLkTinCCrrdEXMTdPiFp4Y4gE4zqNVYQZFFSXWEmH-r@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052235400.31692-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2010/8/5 Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>:
> From: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
>
> The return -EINVAL appears to only make sense if the if branch that it is
> aligned with is taken, so move it into that branch
What a nasty bug to see, thanks for robot-finding this!
Acked-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Yours,
Linus Walleij
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
prev parent reply other threads:[~2010-08-05 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 20:24 [PATCH 26/42] drivers/spi: Adjust confusing if indentation Julia Lawall
2010-08-05 20:30 ` David Brownell
[not found] ` <921858.63779.qm-4JhmkcZgSkn6X00i2u5GFvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-08-05 20:36 ` [PATCH 26/42] drivers/spi/amba-pl022.c: " Julia Lawall
[not found] ` <Pine.LNX.4.64.1008052235400.31692-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2010-08-05 21:41 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinCCrrdEXMTdPiFp4Y4gE4zqNVYQZFFSXWEmH-r@mail.gmail.com \
--to=linus.walleij-0is4wlfg1ojsueelwk9/pw@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=julia-dAYI7NvHqcQ@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).