Re: [PATCH] spi: spidev_test.c: Make transfer size suitable for wordsize 32

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Sat, May 22, 2010 at 8:34 AM, Joakim Tjernlund
<joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org> wrote:
> glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org wrote on 2010/05/22 10:39:38:
>>
>> On Fri, May 14, 2010 at 6:22 AM, Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> > On Fri, May 14, 2010 at 11:14:27AM +0200, Joakim Tjernlund wrote:
>> >>
>> >> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
>> >
>> > Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> I don't think I'll apply this one.  I know it's just sample code, but
>> it still smells of masking a corner case.  If you really want to do
>> this, then I'd suggest adding a runtime switch to change the transfer
>> size.
>
> How so? The current version don't stand a chance to do any ops. with word size 32
> as all transfers has to have a wordsize aligned len. This is not a corner case.

but it also changes the transfer size for 16 and 8 bpw transfers to
something, for lack of a better word, more boring.  I'd rather see a
patch that clamps the transfers size based on the bpw setting.  Bonus
points for a patch that adds the ability to change the transfer size
and/or data from the command line.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------