Re: [PATCH v4] spi: add spi_tegra driver

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Thu, Sep 2, 2010 at 8:22 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> On Wed, Sep 1, 2010 at 4:16 PM, Erik Gilling <konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org> wrote:
>> v2 changes:
>>  from Thierry Reding:
>>    * add "select TEGRA_SYSTEM_DMA" to Kconfig
>>  from Grant Likely:
>>    * add oneline description to header
>>    * inline references to DRIVER_NAME
>>    * inline references to BUSY_TIMEOUT
>>    * open coded bytes_per_word()
>>    * spi_readl/writel -> spi_tegra_readl/writel
>>    * move transfer validation to spi_tegra_transfer
>>    * don't request_mem_region iomem as platform bus does that for us
>>    * __exit -> __devexit
>>
>> v3 changes:
>>  from Russell King:
>>    * put request_mem_region back int
>>  from Grant Likely:
>>    * remove #undef DEBUG
>>    * add SLINK_ to register bit defines
>>    * remove unused bytes_per_word
>>    * make spi_tegra_readl/writel static linine
>>    * various refactoring for clarity
>>    * mark err if BSY bit is not cleared after 1000 retries
>>    * move spinlock to protect setting of RDY bit
>>    * subsys_initcall -> module_init
>>
>> v3 changes:
>>  from Grant Likely:
>>    * update spi_tegra to use PTR_ERRless dma API
>>
>> Signed-off-by: Erik Gilling <konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
>> Cc: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
>> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
>
> Hi Erik,
>
> Go ahead and add my Acked-by line and merge this via the tegra tree to
> avoid ordering issues.  I also have a few more minor comments below.

Hi Erik,

What's the status on this one?  I've not seen it show up in the
for-next branch of the android tegra tree.

g.

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb