* [PATCH] spi-pl022: Add missing return value update
@ 2011-06-13 10:53 Virupax Sadashivpetimath
2011-06-13 15:08 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Virupax Sadashivpetimath @ 2011-06-13 10:53 UTC (permalink / raw)
To: grant.likely
Cc: spi-devel-general, linux-kernel, linus.walleij,
virupax.sadashivpetimath
Return error on out of range cpsdvsr value.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
---
drivers/spi/spi-pl022.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 2541705..b3bd8d8 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -1859,6 +1859,7 @@ static int pl022_setup(struct spi_device *spi)
}
if ((clk_freq.cpsdvsr < CPSDVR_MIN)
|| (clk_freq.cpsdvsr > CPSDVR_MAX)) {
+ status = -EINVAL;
dev_err(&spi->dev,
"cpsdvsr is configured incorrectly\n");
goto err_config_params;
--
1.7.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spi-pl022: Add missing return value update
2011-06-13 10:53 [PATCH] spi-pl022: Add missing return value update Virupax Sadashivpetimath
@ 2011-06-13 15:08 ` Grant Likely
2011-06-13 16:13 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2011-06-13 15:08 UTC (permalink / raw)
To: Virupax Sadashivpetimath; +Cc: spi-devel-general, linux-kernel, linus.walleij
On Mon, Jun 13, 2011 at 04:23:46PM +0530, Virupax Sadashivpetimath wrote:
> Return error on out of range cpsdvsr value.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
It looks like this is a bug fix for v3.0, and probably for -stable too, correct?
g.
> ---
> drivers/spi/spi-pl022.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index 2541705..b3bd8d8 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -1859,6 +1859,7 @@ static int pl022_setup(struct spi_device *spi)
> }
> if ((clk_freq.cpsdvsr < CPSDVR_MIN)
> || (clk_freq.cpsdvsr > CPSDVR_MAX)) {
> + status = -EINVAL;
> dev_err(&spi->dev,
> "cpsdvsr is configured incorrectly\n");
> goto err_config_params;
> --
> 1.7.4.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] spi-pl022: Add missing return value update
2011-06-13 15:08 ` Grant Likely
@ 2011-06-13 16:13 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2011-06-13 16:13 UTC (permalink / raw)
To: Grant Likely; +Cc: Virupax Sadashivpetimath, spi-devel-general, linux-kernel
On Mon, Jun 13, 2011 at 5:08 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Jun 13, 2011 at 04:23:46PM +0530, Virupax Sadashivpetimath wrote:
>> Return error on out of range cpsdvsr value.
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
>
> It looks like this is a bug fix for v3.0, and probably for -stable too, correct?
ACK
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-13 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 10:53 [PATCH] spi-pl022: Add missing return value update Virupax Sadashivpetimath
2011-06-13 15:08 ` Grant Likely
2011-06-13 16:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).