From: Mike Frysinger <vapier.adi@gmail.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Dirk Brandewie <dirk.brandewie@gmail.com>,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: reorganize drivers
Date: Tue, 7 Jun 2011 00:36:38 -0400 [thread overview]
Message-ID: <BANLkTik0rS18wCbzkDqarvmwrEY5vLGp0A@mail.gmail.com> (raw)
In-Reply-To: <4DEDA9C9.6000109@dsn.okisemi.com>
On Tue, Jun 7, 2011 at 00:32, Tomoya MORINAGA wrote:
> (2011/06/07 1:52), Grant Likely wrote:
>> Hahaha. Oops, I can't remember the conversation I had 5 minutes after
>> getting off the phone.
>>
>> It should actually be Tomoya who can comment on the name change.
>
> As far as I know, this change doesn't occur any issue.
> However, I don't have perfect confidence about it.
> Could you give me any information about concern ?
KBUILD_MODNAME is automatically expanded from the file name. so any
code using KBUILD_MODNAME cannot be renamed with 0 side effects. the
question is whether the changed string makes a difference to the
driver.
so if the places where KBUILD_MODNAME is used doesn't actually care
about the contents of the string (and is purely for information
purposes only), then there shouldnt be a problem. but if there is
implicit lookups/matching based on the string, then this is a problem.
-mike
next prev parent reply other threads:[~2011-06-07 4:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 7:18 [PATCH v2] spi: reorganize drivers Grant Likely
2011-06-06 7:27 ` Wolfram Sang
2011-06-06 16:31 ` Mike Frysinger
2011-06-06 16:38 ` Grant Likely
2011-06-06 16:49 ` Dirk Brandewie
2011-06-06 16:52 ` Grant Likely
2011-06-07 4:32 ` Tomoya MORINAGA
2011-06-07 4:36 ` Mike Frysinger [this message]
2011-06-07 2:28 ` Feng Tang
2011-06-07 4:09 ` Grant Likely
[not found] ` <BANLkTim927Ld28JmVfALscThef02XQJDWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-07 4:48 ` Feng Tang
2011-06-07 4:48 ` Mike Frysinger
2011-06-07 4:52 ` Du, Alek
2011-06-07 17:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik0rS18wCbzkDqarvmwrEY5vLGp0A@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=dirk.brandewie@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tomoya-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).