From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2] spi: reorganize drivers Date: Mon, 6 Jun 2011 22:09:52 -0600 Message-ID: References: <20110606071829.10334.90865.stgit@ponder> <4DED0510.1030600@gmail.com> <20110607102829.01392e7e@feng-i7> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Dirk Brandewie , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Mike Frysinger To: Feng Tang Return-path: In-Reply-To: <20110607102829.01392e7e@feng-i7> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang wrote: > On Tue, 7 Jun 2011 00:49:20 +0800 > Dirk Brandewie wrote: > >> On 06/06/2011 09:38 AM, Grant Likely wrote: >> > On Mon, Jun 6, 2011 at 10:31 AM, Mike >> > Frysinger =A0wrote: >> >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote: >> >>> Sort the SPI makefile and enforce the naming convention spi_*.c >> >>> for spi drivers. >> >> >> >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but >> >> perhaps those are only for /proc/ status tracking ? =A0worth doub= le >> >> checking ... >> > >> > I just talked with Dirk Brandewie, who has a major rewrite to the >> > topcliff spi driver. =A0I'll let him comment on whether or not >> > changing KBUILD_MODNAME will cause any problems. >> > >> >> My changes are to the designware driver :-) I will get my patches >> re-based onto the spi-next branch and see if there any issues. > > If there is major rewrite to the dw_spi driver, please submit to this > list, as it is used by many devices out there and needs a broad revie= w Hmmm. Dirk, that could change things a bit. From our conversation today my understanding was that there weren't few if any users outside of your circle. If that isn't the case, then I'm going to be more cautious about merging the rewrite. Who are the people I should make sure there is feedback from when the patch gets posted? g.