linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: viresh kumar <viresh.kumar@st.com>
Cc: Armando VISCONTI <armando.visconti@st.com>,
	"spi-devel-general@lists.sourceforge.net"
	<spi-devel-general@lists.sourceforge.net>,
	viresh kumar <viresh.linux@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Shiraz HASHIM <shiraz.hashim@st.com>
Subject: Re: [QUERY] amba/pl022: DMA channel allocation always fail.
Date: Fri, 13 May 2011 16:31:04 +0200	[thread overview]
Message-ID: <BANLkTinMH9TpTTzqoMPS7JZUBRss3pScWg@mail.gmail.com> (raw)
In-Reply-To: <4DCD1D80.7060409@st.com>

2011/5/13 viresh kumar <viresh.kumar@st.com>:

> amba/pl022 and my dma driver dw_dmac.c, both have registered init() routines
> with subsys_initcall(). Now at bootup, spi boots up before DMA and so DMA
> channels are never available at spi probe.
>
> What should be done to solve this issue?

If you check drivers/dma/ste_dma40.c you can see that our solution was to
simply move the DMA engine to arch_initcall().

Which sort of makes sense for a DMA engine.

Does this work for dw_dmac.c?

> One idea is allocate DMA channel as and when required, instead of allocating them
> at probe. But in that case too i am not sure, that this issue will be solved.

For the serial port I've added a real funny tweak to queue the ports
and add DMA later since these are initialized very early.

Check in drivers/tty/serial/amba-pl011.c

Hope this helps,
Linus Walleij

  reply	other threads:[~2011-05-13 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 12:01 [QUERY] amba/pl022: DMA channel allocation always fail viresh kumar
2011-05-13 14:31 ` Linus Walleij [this message]
     [not found]   ` <BANLkTinMH9TpTTzqoMPS7JZUBRss3pScWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-16  4:45     ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinMH9TpTTzqoMPS7JZUBRss3pScWg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=armando.visconti@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shiraz.hashim@st.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=viresh.kumar@st.com \
    --cc=viresh.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).