* [PATCH 4/4] mach-u300: set apropriate FIFO trigger levels @ 2011-06-16 8:14 Linus Walleij [not found] ` <1308212094-22592-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Linus Walleij @ 2011-06-16 8:14 UTC (permalink / raw) To: Grant Likely, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Cc: Linus Walleij, Lee Jones From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> The U300 just defined the fill level limits for the FIFOs to 1 item out of habit. It can easily handle four. Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> --- arch/arm/mach-u300/spi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-u300/spi.c b/arch/arm/mach-u300/spi.c index 5767208..7b597e2 100644 --- a/arch/arm/mach-u300/spi.c +++ b/arch/arm/mach-u300/spi.c @@ -40,8 +40,8 @@ struct pl022_config_chip dummy_chip_info = { .hierarchy = SSP_MASTER, /* 0 = drive TX even as slave, 1 = do not drive TX as slave */ .slave_tx_disable = 0, - .rx_lev_trig = SSP_RX_1_OR_MORE_ELEM, - .tx_lev_trig = SSP_TX_1_OR_MORE_EMPTY_LOC, + .rx_lev_trig = SSP_RX_4_OR_MORE_ELEM, + .tx_lev_trig = SSP_TX_4_OR_MORE_EMPTY_LOC, .ctrl_len = SSP_BITS_12, .wait_state = SSP_MWIRE_WAIT_ZERO, .duplex = SSP_MICROWIRE_CHANNEL_FULL_DUPLEX, -- 1.7.3.2 ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1308212094-22592-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>]
* Re: [PATCH 4/4] mach-u300: set apropriate FIFO trigger levels [not found] ` <1308212094-22592-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> @ 2011-06-16 12:22 ` Grant Likely [not found] ` <20110616122235.GA31534-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Grant Likely @ 2011-06-16 12:22 UTC (permalink / raw) To: Linus Walleij Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Linus Walleij, Lee Jones On Thu, Jun 16, 2011 at 10:14:54AM +0200, Linus Walleij wrote: > From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > The U300 just defined the fill level limits for the FIFOs to > 1 item out of habit. It can easily handle four. > > Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> I assume this one will go via your tree? g. > --- > arch/arm/mach-u300/spi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-u300/spi.c b/arch/arm/mach-u300/spi.c > index 5767208..7b597e2 100644 > --- a/arch/arm/mach-u300/spi.c > +++ b/arch/arm/mach-u300/spi.c > @@ -40,8 +40,8 @@ struct pl022_config_chip dummy_chip_info = { > .hierarchy = SSP_MASTER, > /* 0 = drive TX even as slave, 1 = do not drive TX as slave */ > .slave_tx_disable = 0, > - .rx_lev_trig = SSP_RX_1_OR_MORE_ELEM, > - .tx_lev_trig = SSP_TX_1_OR_MORE_EMPTY_LOC, > + .rx_lev_trig = SSP_RX_4_OR_MORE_ELEM, > + .tx_lev_trig = SSP_TX_4_OR_MORE_EMPTY_LOC, > .ctrl_len = SSP_BITS_12, > .wait_state = SSP_MWIRE_WAIT_ZERO, > .duplex = SSP_MICROWIRE_CHANNEL_FULL_DUPLEX, > -- > 1.7.3.2 > ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20110616122235.GA31534-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>]
* Re: [PATCH 4/4] mach-u300: set apropriate FIFO trigger levels [not found] ` <20110616122235.GA31534-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> @ 2011-06-16 15:08 ` Linus Walleij 0 siblings, 0 replies; 3+ messages in thread From: Linus Walleij @ 2011-06-16 15:08 UTC (permalink / raw) To: Grant Likely Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Lee Jones, Linus Walleij On Thu, Jun 16, 2011 at 2:22 PM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote: > On Thu, Jun 16, 2011 at 10:14:54AM +0200, Linus Walleij wrote: >> From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> >> The U300 just defined the fill level limits for the FIFOs to >> 1 item out of habit. It can easily handle four. >> >> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > I assume this one will go via your tree? Yeah they can be merged out-of-order so I'll take it. Thanks for fast action! Linus Walleij ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-16 15:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-16 8:14 [PATCH 4/4] mach-u300: set apropriate FIFO trigger levels Linus Walleij [not found] ` <1308212094-22592-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> 2011-06-16 12:22 ` Grant Likely [not found] ` <20110616122235.GA31534-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> 2011-06-16 15:08 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).