From: Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Aravind Thokala
<aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/2] spi/ath79: Fix checkpatch warnings
Date: Tue, 27 Jun 2017 21:51:30 +0530 [thread overview]
Message-ID: <CAAUiYHe3p-D_-2MLW+a0LsfmOZYyjNunvSi8W2KzmvZpgPDXPw@mail.gmail.com> (raw)
In-Reply-To: <1498579857-10236-1-git-send-email-aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Kindly ignore this patch: Mistakenly the patch subject contains [PATCH 2/2].
I will resend the patch.
On 27 June 2017 at 21:40, Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
>
> Signed-off-by: Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/spi/spi-ath79.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
> index b89cee1..0719bd4 100644
> --- a/drivers/spi/spi-ath79.c
> +++ b/drivers/spi/spi-ath79.c
> @@ -39,15 +39,15 @@ struct ath79_spi {
> u32 reg_ctrl;
> void __iomem *base;
> struct clk *clk;
> - unsigned rrw_delay;
> + unsigned int rrw_delay;
> };
>
> -static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg)
> +static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg)
> {
> return ioread32(sp->base + reg);
> }
>
> -static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val)
> +static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val)
> {
> iowrite32(val, sp->base + reg);
> }
> @@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi)
> return spi_master_get_devdata(spi->master);
> }
>
> -static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs)
> +static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs)
> {
> if (nsecs > sp->rrw_delay)
> ndelay(nsecs - sp->rrw_delay);
> @@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
>
> static void ath79_spi_cleanup_cs(struct spi_device *spi)
> {
> - if (gpio_is_valid(spi->cs_gpio)) {
> + if (gpio_is_valid(spi->cs_gpio))
> gpio_free(spi->cs_gpio);
> - }
> }
>
> static int ath79_spi_setup(struct spi_device *spi)
> @@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi)
> spi_bitbang_cleanup(spi);
> }
>
> -static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs,
> +static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs,
> u32 word, u8 bits)
> {
> struct ath79_spi *sp = ath79_spidev_to_sp(spi);
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-27 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 16:10 [PATCH 2/2] spi/ath79: Fix checkpatch warnings Aravind Thokala
[not found] ` <1498579857-10236-1-git-send-email-aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-27 16:21 ` Aravind Thokala [this message]
2017-07-10 18:42 ` Applied "spi/ath79: Fix checkpatch warnings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAUiYHe3p-D_-2MLW+a0LsfmOZYyjNunvSi8W2KzmvZpgPDXPw@mail.gmail.com \
--to=aravind.thk-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).