From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
Bangzheng Liu <bangzheng.liu@unisoc.com>
Subject: Re: [PATCH] spi: sprd: add runtime pm for transfer message
Date: Mon, 2 Nov 2020 11:17:30 +0800 [thread overview]
Message-ID: <CAAfSe-sTUptZKq9v8MqW247cXPnh__QKmNe9+M458owtB82Pfg@mail.gmail.com> (raw)
In-Reply-To: <20201030134227.GC4405@sirena.org.uk>
On Fri, 30 Oct 2020 at 21:42, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Oct 30, 2020 at 03:24:44PM +0800, Chunyan Zhang wrote:
> > From: Bangzheng Liu <bangzheng.liu@unisoc.com>
> >
> > Before transfer one message, spi core would set chipselect, sprd spi
> > device should be resumed from runtime suspend, otherwise kernel would
> > crash once access spi registers. The sprd spi device can be suspended
> > until clearing chipselect which would be executed after transfer.
>
> The core should be handling runtime PM for normal transfers, if it's not
> managing to do that then we should fix the core so it's fixed for all
> drivers not just this one.
Sure, I will send a new patch.
prev parent reply other threads:[~2020-11-02 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 7:24 [PATCH] spi: sprd: add runtime pm for transfer message Chunyan Zhang
2020-10-30 13:42 ` Mark Brown
2020-11-02 3:17 ` Chunyan Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAfSe-sTUptZKq9v8MqW247cXPnh__QKmNe9+M458owtB82Pfg@mail.gmail.com \
--to=zhang.lyra@gmail.com \
--cc=bangzheng.liu@unisoc.com \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=chunyan.zhang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=orsonzhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).