* [PATCH] spi: sprd: add runtime pm for transfer message
@ 2020-10-30 7:24 Chunyan Zhang
2020-10-30 13:42 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Chunyan Zhang @ 2020-10-30 7:24 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi, linux-kernel, Orson Zhai, Baolin Wang, Chunyan Zhang,
Chunyan Zhang, Bangzheng Liu
From: Bangzheng Liu <bangzheng.liu@unisoc.com>
Before transfer one message, spi core would set chipselect, sprd spi
device should be resumed from runtime suspend, otherwise kernel would
crash once access spi registers. The sprd spi device can be suspended
until clearing chipselect which would be executed after transfer.
Fixes: e7d973a31c24 ("spi: sprd: Add SPI driver for Spreadtrum SC9860")
Signed-off-by: Bangzheng Liu <bangzheng.liu@unisoc.com>
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
drivers/spi/spi-sprd.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
index 635738f54c73..1733d10eb296 100644
--- a/drivers/spi/spi-sprd.c
+++ b/drivers/spi/spi-sprd.c
@@ -293,15 +293,25 @@ static void sprd_spi_chipselect(struct spi_device *sdev, bool cs)
struct spi_controller *sctlr = sdev->controller;
struct sprd_spi *ss = spi_controller_get_devdata(sctlr);
u32 val;
+ int ret;
- val = readl_relaxed(ss->base + SPRD_SPI_CTL0);
/* The SPI controller will pull down CS pin if cs is 0 */
if (!cs) {
- val &= ~SPRD_SPI_CS0_VALID;
+ ret = pm_runtime_get_sync(ss->dev);
+ if (ret < 0) {
+ pm_runtime_put_noidle(ss->dev);
+ dev_err(ss->dev, "Failed to power device: %d\n", ret);
+ return;
+ }
+ val = readl_relaxed(ss->base + SPRD_SPI_CTL0);
+ val &= ~SPRD_SPI_CS0_VALID; /* set cs0 valid */
writel_relaxed(val, ss->base + SPRD_SPI_CTL0);
} else {
- val |= SPRD_SPI_CSN_MASK;
+ val = readl_relaxed(ss->base + SPRD_SPI_CTL0);
+ val |= SPRD_SPI_CSN_MASK; /* set all cs invalid */
writel_relaxed(val, ss->base + SPRD_SPI_CTL0);
+ pm_runtime_mark_last_busy(ss->dev);
+ pm_runtime_put_autosuspend(ss->dev);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spi: sprd: add runtime pm for transfer message
2020-10-30 7:24 [PATCH] spi: sprd: add runtime pm for transfer message Chunyan Zhang
@ 2020-10-30 13:42 ` Mark Brown
2020-11-02 3:17 ` Chunyan Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2020-10-30 13:42 UTC (permalink / raw)
To: Chunyan Zhang
Cc: linux-spi, linux-kernel, Orson Zhai, Baolin Wang, Chunyan Zhang,
Bangzheng Liu
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Fri, Oct 30, 2020 at 03:24:44PM +0800, Chunyan Zhang wrote:
> From: Bangzheng Liu <bangzheng.liu@unisoc.com>
>
> Before transfer one message, spi core would set chipselect, sprd spi
> device should be resumed from runtime suspend, otherwise kernel would
> crash once access spi registers. The sprd spi device can be suspended
> until clearing chipselect which would be executed after transfer.
The core should be handling runtime PM for normal transfers, if it's not
managing to do that then we should fix the core so it's fixed for all
drivers not just this one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: sprd: add runtime pm for transfer message
2020-10-30 13:42 ` Mark Brown
@ 2020-11-02 3:17 ` Chunyan Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Chunyan Zhang @ 2020-11-02 3:17 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi, Linux Kernel Mailing List, Orson Zhai, Baolin Wang,
Chunyan Zhang, Bangzheng Liu
On Fri, 30 Oct 2020 at 21:42, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Oct 30, 2020 at 03:24:44PM +0800, Chunyan Zhang wrote:
> > From: Bangzheng Liu <bangzheng.liu@unisoc.com>
> >
> > Before transfer one message, spi core would set chipselect, sprd spi
> > device should be resumed from runtime suspend, otherwise kernel would
> > crash once access spi registers. The sprd spi device can be suspended
> > until clearing chipselect which would be executed after transfer.
>
> The core should be handling runtime PM for normal transfers, if it's not
> managing to do that then we should fix the core so it's fixed for all
> drivers not just this one.
Sure, I will send a new patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 3:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 7:24 [PATCH] spi: sprd: add runtime pm for transfer message Chunyan Zhang
2020-10-30 13:42 ` Mark Brown
2020-11-02 3:17 ` Chunyan Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).