linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Padma Venkat <padma.kvr@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller
Date: Mon, 10 Nov 2014 10:20:27 +0530	[thread overview]
Message-ID: <CAAgF-Bd=S7-PoA7GZoy87W9Dem3OXVhc1tL-eyWEAHvF0LPTKQ@mail.gmail.com> (raw)
In-Reply-To: <20141107101310.GA8509@sirena.org.uk>

Hi Mark,

On 11/7/14, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote:
>
>> CS can also be controlled automatically by setting AUTO_N_MANUAL to 1
>> in CS_CFG. When it is auto CS automatically toggles between packet to
>> packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The
>> driver by default uses manual mode. But on exynos7 the manual mode is
>> removed.
>
> OK, but what's a packet here?

Packet is either 1 byte or 4 bytes size depends on width of the SPI channel.

>
>> I tested the driver with wm5110 codec.
>
> Did you try firmware downloads or something else that generates multiple
> transfers in a message?  Normal register writes will use a single
> transfer so I'd expect them to just work.
>

OK. I don't have provision to test on this board. I will try to test
on older boards by disabling manual mode.

Thanks
padma

  reply	other threads:[~2014-11-10  4:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  9:51 [PATCH] spi: s3c64xx: add support for exynos7 SPI controller Padmavathi Venna
2014-11-06 10:26 ` Mark Brown
     [not found]   ` <20141106102636.GT8509-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-07  8:31     ` Padma Venkat
2014-11-07 10:13       ` Mark Brown
2014-11-10  4:50         ` Padma Venkat [this message]
     [not found]           ` <CAAgF-Bd=S7-PoA7GZoy87W9Dem3OXVhc1tL-eyWEAHvF0LPTKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-14 11:16             ` Padma Venkat
     [not found]               ` <CAAgF-BcARoRZv=BPqQWyp6rJQQ=CE0FEUz_2vgQSpeZyLwbkBw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21  7:08                 ` Padma Venkat
2014-11-25  3:07                   ` Padma Venkat
     [not found] ` <1415267509-16653-1-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-26 19:01   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAgF-Bd=S7-PoA7GZoy87W9Dem3OXVhc1tL-eyWEAHvF0LPTKQ@mail.gmail.com' \
    --to=padma.kvr@gmail.com \
    --cc=broonie@kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).