From mboxrd@z Thu Jan 1 00:00:00 1970 From: Padma Venkat Subject: Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller Date: Fri, 21 Nov 2014 12:38:38 +0530 Message-ID: References: <1415267509-16653-1-git-send-email-padma.v@samsung.com> <20141106102636.GT8509@sirena.org.uk> <20141107101310.GA8509@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim To: Mark Brown Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi Mark, >>>> CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 >>>> in CS_CFG. When it is auto CS automatically toggles between packet to >>>> packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The >>>> driver by default uses manual mode. But on exynos7 the manual mode is >>>> removed. >>> >>> OK, but what's a packet here? >> >> Packet is either 1 byte or 4 bytes size depends on width of the SPI >> channel. >> >>> >>>> I tested the driver with wm5110 codec. >>> >>> Did you try firmware downloads or something else that generates multiple >>> transfers in a message? Normal register writes will use a single >>> transfer so I'd expect them to just work. >>> >> >> OK. I don't have provision to test on this board. I will try to test >> on older boards by disabling manual mode. >> > > I tested on exynos5420 peach-pit by enabling auto mode. I used dd > command to read 1MB data from spi flash and I compared the result with > manual mode. Both are same. I also tested this patch with Javier Martinez Canillas patches for enabling spidev nodes from http://www.spinics.net/lists/linux-samsung-soc/msg39057.html. I read 4MB flashdata from spi by enabling auto mode and compared the result. They look same. > >> Thanks >> padma >> > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html