From: Antonio Borneo <borneo.antonio@gmail.com>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Zhong Kaihua <zhongkaihua@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
xuwei5@hisilicon.com, linux-spi@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0
Date: Tue, 21 Mar 2017 20:13:29 +0100 [thread overview]
Message-ID: <CAAj6DX3kvc-wy+xSPBC26Xw0s6BBApTJQGrVS1BsiFgfDybBbw@mail.gmail.com> (raw)
In-Reply-To: <20170321070818.3247-1-guodong.xu@linaro.org>
On Tue, Mar 21, 2017 at 8:08 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> From: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
>
> Enable DMA in spi0.
Hi Guodong, Xiaoyin,
added linux-spi in copy.
Actually the patch does not enable the DMA. The commit message is not correct.
> Cc: Antonio Borneo <borneo.antonio@gmail.com>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 470461d..e40625f 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -682,7 +682,8 @@
> reg = <0x0 0xf7106000 0x0 0x1000>;
> interrupts = <0 50 4>;
> bus-id = <0>;
> - enable-dma = <0>;
> + dmas = <&dma0 0 &dma0 1>;
> + dma-names = "rx", "tx";
The controller spi0 is a standard ARM PL022.
This patch removes the nonexistent property "enable-dma" and specifies
which DMA controller and which DMA channels are connected to spi0.
The values are coherent with the documentation available for hi6220.
Apart from the commit message, I'm fine with this patch.
On PL022 the DMA is not enabled in the DT node of the controller but
in the DT node of each spi device, through the property
"pl022,com-mode".
A separate patch should eventually enable the DMA for those spi
devices that require it.
Best Regards,
Antonio
> clocks = <&sys_ctrl HI6220_SPI_CLK>;
> clock-names = "apb_pclk";
> pinctrl-names = "default";
> --
> 2.10.2
>
parent reply other threads:[~2017-03-21 19:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170321070818.3247-1-guodong.xu@linaro.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAj6DX3kvc-wy+xSPBC26Xw0s6BBApTJQGrVS1BsiFgfDybBbw@mail.gmail.com \
--to=borneo.antonio@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=hw.wangxiaoyin@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=zhongkaihua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).