Re: [PATCH 3/3] spi: create an optional message queueing infrastructure

[Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On Thu, Feb 2, 2012 at 7:52 PM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:

> This looks really good.  In fact, can you think of any reason why we wouldn't
> force all spi drivers to use central queueing?  I don't see any advantage
> in leaving the old mechanism in place other than to allow driver to transition
> from the old API.

Not really... except that it'll be hard to convert all drivers.

> There is also the spi_bitbang which also implements its own message
> queue and workqueue.  Several drivers make use of even if they don't
> do bitbanging.

Sound like they're abusing it then :-/

> Can you investigate dropping patch 2 and making the normal register
> function set up queued transfers if the transfer hook is not set.  If
> it is set, then make the kernel complain to the console, quietly at
> first, but we'll get louder before ultimately removing the
> non-queued interface.  Thoughts?

OK I'll post v2 soon with these changes.

Thanks,
Linus Walleij

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2