[PATCH] spi: bcm53xx: (re)license code to the GPL v2

[PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Rafał Miłecki]

From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>

My intention was to release this code under GPL v2 license. For some
reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
controller on Broadcom bcma SoC") totally missed licensing info.
MODULE_LICENSE was later added by Axel specifying "GNU Public License
v2 or later".

This patch clarifies situation by adding a proper header (with Copyright
line) and adjusting MODULE_LICENSE. It should be acked by every driver
contributor.

Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
---
Guys, can I have your Acked-by for this patch, please?

Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust
devm usage")

Joe: you are author of commit f7219b527b57 ("treewide: Remove
unnecessary BCMA_CORETABLE_END macro")

Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use
msecs_to_jiffies for conversion")

Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing
module information")

Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local
symbol static")
---
 drivers/spi/spi-bcm53xx.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c
index 0c61ad4..6e409ea 100644
--- a/drivers/spi/spi-bcm53xx.c
+++ b/drivers/spi/spi-bcm53xx.c
@@ -1,3 +1,11 @@
+/*
+ * Copyright (C) 2014-2016 Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
 #define pr_fmt(fmt)		KBUILD_MODNAME ": " fmt
 
 #include <linux/kernel.h>
@@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit);
 
 MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
 MODULE_AUTHOR("Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
-- 
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Nicholas Mc Guire]

On Thu, Dec 29, 2016 at 08:13:13PM +0100, Rafa?? Mi??ecki wrote:
> From: Rafa?? Mi??ecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> 
> My intention was to release this code under GPL v2 license. For some
> reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
> controller on Broadcom bcma SoC") totally missed licensing info.
> MODULE_LICENSE was later added by Axel specifying "GNU Public License
> v2 or later".
> 
> This patch clarifies situation by adding a proper header (with Copyright
> line) and adjusting MODULE_LICENSE. It should be acked by every driver
> contributor.
> 
> Signed-off-by: Rafa?? Mi??ecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> ---
> Guys, can I have your Acked-by for this patch, please?
> 
> Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust
> devm usage")
> 
> Joe: you are author of commit f7219b527b57 ("treewide: Remove
> unnecessary BCMA_CORETABLE_END macro")
> 
> Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use
> msecs_to_jiffies for conversion")
> 
> Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing
> module information")
> 
> Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local
> symbol static")

Acked-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>

> ---
>  drivers/spi/spi-bcm53xx.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c
> index 0c61ad4..6e409ea 100644
> --- a/drivers/spi/spi-bcm53xx.c
> +++ b/drivers/spi/spi-bcm53xx.c
> @@ -1,3 +1,11 @@
> +/*
> + * Copyright (C) 2014-2016 Rafa?? Mi??ecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
>  #define pr_fmt(fmt)		KBUILD_MODNAME ": " fmt
>  
>  #include <linux/kernel.h>
> @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit);
>  
>  MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
>  MODULE_AUTHOR("Rafa?? Mi??ecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.10.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Rafał Miłecki]

Sending using Jingoo's new address.

Jingoo: can I have your Acked-by as requested below, please?

On 12/29/2016 08:13 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> My intention was to release this code under GPL v2 license. For some
> reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
> controller on Broadcom bcma SoC") totally missed licensing info.
> MODULE_LICENSE was later added by Axel specifying "GNU Public License
> v2 or later".
>
> This patch clarifies situation by adding a proper header (with Copyright
> line) and adjusting MODULE_LICENSE. It should be acked by every driver
> contributor.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> ---
> Guys, can I have your Acked-by for this patch, please?
>
> Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust
> devm usage")
>
> Joe: you are author of commit f7219b527b57 ("treewide: Remove
> unnecessary BCMA_CORETABLE_END macro")
>
> Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use
> msecs_to_jiffies for conversion")
>
> Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing
> module information")
>
> Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local
> symbol static")
> ---

>  drivers/spi/spi-bcm53xx.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c
> index 0c61ad4..6e409ea 100644
> --- a/drivers/spi/spi-bcm53xx.c
> +++ b/drivers/spi/spi-bcm53xx.c
> @@ -1,3 +1,11 @@
> +/*
> + * Copyright (C) 2014-2016 Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
>  #define pr_fmt(fmt)		KBUILD_MODNAME ": " fmt
>
>  #include <linux/kernel.h>
> @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit);
>
>  MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
>  MODULE_AUTHOR("Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Rafał Miłecki]

On 30 December 2016 at 05:30, Han Jingoo <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Thank you for sending me the patch.
> Your patch looks good.
>
> But, I am not a maintainer for this bcm53xx SPI driver.
> So, I think that my reviewed-by is enough, instead of my acked-by.
> However, you can select either one.
>
> Reviewed-by: Jingoo Han <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> or
> Acked-by: Jingoo Han <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

According to the Documentation/development-process/5.Posting.rst this
"Acked-by" is *often* used by maintainers, but it isn't a requirement.
It also "indicates an agreement" which should be clear enough for
(re)licensing code. So I think it's justified to use "Acked-by" in
this case. I can also see similar usage of it in "git log" of kernel
source so I hope it's really OK :)
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Joe Perches]

On Thu, 2016-12-29 at 20:13 +0100, Rafał Miłecki wrote:
> My intention was to release this code under GPL v2 license.
[]
> Joe: you are author of commit f7219b527b57 ("treewide: Remove
> unnecessary BCMA_CORETABLE_END macro")

Acked-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Axel Lin]

2016-12-30 3:13 GMT+08:00 Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> My intention was to release this code under GPL v2 license. For some
> reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
> controller on Broadcom bcma SoC") totally missed licensing info.
> MODULE_LICENSE was later added by Axel specifying "GNU Public License
> v2 or later".
>
> This patch clarifies situation by adding a proper header (with Copyright
> line) and adjusting MODULE_LICENSE. It should be acked by every driver
> contributor.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> ---
> Guys, can I have your Acked-by for this patch, please?
>
> Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust
> devm usage")
>
> Joe: you are author of commit f7219b527b57 ("treewide: Remove
> unnecessary BCMA_CORETABLE_END macro")
>
> Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use
> msecs_to_jiffies for conversion")
>
> Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing
> module information")

Acked-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Vaishali Thakkar]

On Fri, Dec 30, 2016 at 12:43 AM, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> My intention was to release this code under GPL v2 license. For some
> reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
> controller on Broadcom bcma SoC") totally missed licensing info.
> MODULE_LICENSE was later added by Axel specifying "GNU Public License
> v2 or later".
>
> This patch clarifies situation by adding a proper header (with Copyright
> line) and adjusting MODULE_LICENSE. It should be acked by every driver
> contributor.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> ---
> Guys, can I have your Acked-by for this patch, please?

I am no longer using this mail address for the kernel contribution, so
adding acked by with the new mail address.

Thanks.

> Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust
> devm usage")

Acked-by: Vaishali Thakkar <vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> Joe: you are author of commit f7219b527b57 ("treewide: Remove
> unnecessary BCMA_CORETABLE_END macro")
>
> Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use
> msecs_to_jiffies for conversion")
>
> Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing
> module information")
>
> Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local
> symbol static")
> ---
>  drivers/spi/spi-bcm53xx.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c
> index 0c61ad4..6e409ea 100644
> --- a/drivers/spi/spi-bcm53xx.c
> +++ b/drivers/spi/spi-bcm53xx.c
> @@ -1,3 +1,11 @@
> +/*
> + * Copyright (C) 2014-2016 Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
>  #define pr_fmt(fmt)            KBUILD_MODNAME ": " fmt
>
>  #include <linux/kernel.h>
> @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit);
>
>  MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
>  MODULE_AUTHOR("Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> --
> 2.10.1
>



-- 
Vaishali
http://vaishalithakkar.in/
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Rafał Miłecki]

On 29 December 2016 at 20:13, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> My intention was to release this code under GPL v2 license. For some
> reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI
> controller on Broadcom bcma SoC") totally missed licensing info.
> MODULE_LICENSE was later added by Axel specifying "GNU Public License
> v2 or later".
>
> This patch clarifies situation by adding a proper header (with Copyright
> line) and adjusting MODULE_LICENSE. It should be acked by every driver
> contributor.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>

Hi Mark,

For some reason patchwork missed Han's reply:
https://patchwork.kernel.org/patch/9491361/
but all other ones are there.

Could you get patch as mbox from patchwork:
https://patchwork.kernel.org/patch/9491361/mbox/
and add Han's "Acked-by" manually?

This would give you a patch acked by every contributor which should be
enough to push is safely/legally.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Fri, Dec 30, 2016 at 09:08:30AM +0100, Rafał Miłecki wrote:
> On 29 December 2016 at 20:13, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Could you get patch as mbox from patchwork:
> https://patchwork.kernel.org/patch/9491361/mbox/
> and add Han's "Acked-by" manually?

> This would give you a patch acked by every contributor which should be
> enough to push is safely/legally.

Please allow a reasonable period for a reply before sending pings,
unless things are *extremely* urgent 24 hours isn't particularly
reasonable.  I do review from e-mail not from patchwork (I'm pretty sure
it's a vanishingly small minority of people who do review from patchwork
alone) but it was Christmas.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: bcm53xx: (re)license code to the GPL v2

[Rafał Miłecki]

On 6 January 2017 at 19:21, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Dec 30, 2016 at 09:08:30AM +0100, Rafał Miłecki wrote:
>> On 29 December 2016 at 20:13, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> Could you get patch as mbox from patchwork:
>> https://patchwork.kernel.org/patch/9491361/mbox/
>> and add Han's "Acked-by" manually?
>
>> This would give you a patch acked by every contributor which should be
>> enough to push is safely/legally.
>
> Please allow a reasonable period for a reply before sending pings,
> unless things are *extremely* urgent 24 hours isn't particularly
> reasonable.  I do review from e-mail not from patchwork (I'm pretty sure
> it's a vanishingly small minority of people who do review from patchwork
> alone) but it was Christmas.

I never meant to rush you, I was just trying to be helpful. I wanted
to just let you know all ppl I asked sent their Acks & I wanted to
give you a notice on possible problem with patchwork & Han's Ack. I
didn't want to put effort of tracing Acks on you.

Take your time, handle it whenever you have time for this, this isn't urgent :)

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html