From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
"Van Puymbroeck,
Dries"
<Dries.VanPuymbroeck-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>,
Peter Korsgaard
<peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer
Date: Sat, 2 Mar 2013 14:31:12 +0000 [thread overview]
Message-ID: <CACxGe6tpjFygsmMtpN6dUA5o78t=x0Qp3o2OOmXouAD=NgpFgQ@mail.gmail.com> (raw)
In-Reply-To: <20130302104853.GA31872-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Sat, Mar 2, 2013 at 10:48 AM, Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> On Sat, Mar 02, 2013 at 11:43:58AM +0100, Peter Korsgaard wrote:
>
>> MB> This looks wrong without a vendor name in it but I'm not sure what we're
>> MB> supposed to do for generic stuff like this.
>
>> It's atleast in line with what we do elsewhere (spi-gpio, i2c-gpio,
>> i2c-mux-gpio, ..)
>
> Yup, it just feels wrong. Not a problem though. Will you respin for
> the max speed thing?
It's not quite the same though. spi-gpio and i2c-gpio are very well
defined things. An SPI multiplexer on the other hand can be
implemented in several different ways. I would still be more specific
here. You can be specific to your specific hardware now, and a more
generic value can be added later.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
next prev parent reply other threads:[~2013-03-02 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 13:58 [PATCH] spi: Driver for GPIO controlled SPI multiplexer Peter Korsgaard
[not found] ` <20130302035043.GE6610@opensource.wolfsonmicro.com>
[not found] ` <20130302035043.GE6610-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-02 10:43 ` Peter Korsgaard
[not found] ` <20130302104853.GA31872@opensource.wolfsonmicro.com>
[not found] ` <20130302104853.GA31872-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-02 11:15 ` Peter Korsgaard
2013-03-02 14:31 ` Grant Likely [this message]
[not found] ` <1361973519-30633-1-git-send-email-peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
2013-03-02 17:32 ` Grant Likely
2013-03-03 8:08 ` Peter Korsgaard
[not found] ` <20130303074209.GA19020@opensource.wolfsonmicro.com>
[not found] ` <20130303074209.GA19020-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-04 2:38 ` Grant Likely
2013-03-26 21:14 ` [PATCH] spi: Add SPI mux core and GPIO-based mux driver Dries Van Puymbroeck
[not found] ` <1364332460-4808-1-git-send-email-Dries.VanPuymbroeck-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
2013-04-09 8:19 ` Van Puymbroeck, Dries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACxGe6tpjFygsmMtpN6dUA5o78t=x0Qp3o2OOmXouAD=NgpFgQ@mail.gmail.com' \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=Dries.VanPuymbroeck-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).