From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v4 0/7] mtd: spi-nor: add a new framework for SPI NOR Date: Fri, 17 Jan 2014 14:09:58 +0530 Message-ID: References: <1387950629-27448-1-git-send-email-b32955@freescale.com> <52D7A237.8@freescale.com> <20140117020226.GB27652@shlinux2.ap.freescale.net> <20140117065401.GA6140@shlinux2.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: David Woodhouse , angus.clark@st.com, Shawn Guo , b44548@freescale.com, Mark Brown , linux-doc@vger.kernel.org, b18965@freescale.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, "Gupta, Pekon" , Sourav Poddar , Brian Norris , Lee Jones , "linux-arm-kernel@lists.infradead.org" To: Huang Shijie Return-path: In-Reply-To: <20140117065401.GA6140@shlinux2.ap.freescale.net> Sender: linux-doc-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Fri, Jan 17, 2014 at 12:24 PM, Huang Shijie wrote: > On Fri, Jan 17, 2014 at 12:36:08PM +0530, Jagan Teki wrote: >> >> My basic question is like I have a qspi spi controller in my SOC and I >> >> designed two boards B1 and B2 >> > >> > okay. >> > >> >> B1 with quad spi controller connected with non-flash as a slave and B2 >> >> with quad spi controller connected >> >> with quad flash as a slave. >> > You can use the framework for B2. But for B1, you should not use the framework, >> > since this framework is just for the SPI-NOR. If you do not connected with >> > a NOR, i think it's better to code another driver for your controller. >> >> Means we have two separate controller drivers for same controller one >> with spi-nor and >> another with spi is it? > Take drivers/spi/spi-imx.c for example, if you connect a NOR to it, you only > need to add a NOR device node in the device tree. In the probe, it will call > the m25p80.c to probe the NOR device. > > But if we connect other device to it. you should set another device node for it. > > I am not sure if your controller driver can works as the spi-imx.c My question here was - this new framework suggest to write a two different controller drivers one is for non spi-nor and spi-nor models? do you agree that? And also one important note from your design was spi-nor mode is completely bypassing Linux spi core is that the good idea? -- Thanks, Jagan.