From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-spi@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Stephen McCamant <smccaman@umn.edu>,
Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] spi: gpio: prevent memory leak in spi_gpio_probe
Date: Tue, 1 Oct 2019 12:32:41 -0500 [thread overview]
Message-ID: <CAEkB2ES3-gotqS9184izf0fKOigFaFUetBiqekmYJPBgPWbSBQ@mail.gmail.com> (raw)
In-Reply-To: <6b55e753-5797-2bdc-fae6-f575a0ef8186@web.de>
Hi Markus, thanks for your suggestions for improving the quality of
the patch. At the moment I prefer first get a confirmation from
contributors about the leak and then work on any possible improvements
for the patch.
Thanks,
Navid.
On Tue, Oct 1, 2019 at 4:11 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > … In order to avoid leak spi_contriller_put must
> > be called in case of failure for devm_add_action_or_reset.
>
> How does this wording fit to the diff display that you would like
> to add the function call “spi_master_put(master)” in
> one if branch?
>
>
> > Fixes: 8b797490b4db ("spi: gpio: Make sure spi_master_put() is called in every error path")
>
> Is there a need to complete the corresponding exception handling
> at any more source code places?
>
> Regards,
> Markus
--
Navid.
next prev parent reply other threads:[~2019-10-01 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 3:39 [PATCH] spi: gpio: prevent memroy leak in spi_gpio_probe Navid Emamdoost
2019-09-30 6:24 ` [PATCH] spi: gpio: prevent memory " Markus Elfring
2019-09-30 20:52 ` [PATCH v2] " Navid Emamdoost
2019-10-01 9:11 ` Markus Elfring
2019-10-01 17:32 ` Navid Emamdoost [this message]
2019-10-02 5:07 ` [v2] " Markus Elfring
2019-10-01 17:57 ` Applied "spi: gpio: prevent memory leak in spi_gpio_probe" to the spi tree Mark Brown
2019-09-30 20:54 ` [PATCH] spi: gpio: prevent memory leak in spi_gpio_probe Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEkB2ES3-gotqS9184izf0fKOigFaFUetBiqekmYJPBgPWbSBQ@mail.gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=broonie@kernel.org \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).