From: Alexandre Mergnat <amergnat@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Amjad Ouled-Ameur <aouledameur@baylibre.com>,
linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: spidev: add new mediatek support
Date: Thu, 19 Jan 2023 20:30:15 +0100 [thread overview]
Message-ID: <CAFGrd9pZ0Lso6LMKkN=ErujGgRi6t5_C3FvbMYHaV5V_DD0BnA@mail.gmail.com> (raw)
In-Reply-To: <Y8l/mQjjgKJiE1/F@sirena.org.uk>
Le jeu. 19 janv. 2023 à 18:36, Mark Brown <broonie@kernel.org> a écrit :
>
> On Thu, Jan 19, 2023 at 06:28:20PM +0100, Alexandre Mergnat wrote:
> > Add the "mediatek,genio" compatible string to support Mediatek
> > SPI controller on the genio boards.
>
> All my previous review comments stand, please don't ignore review
> feedback.
Hi Mark,
Yes sorry about that, I wasn't aware that I've some feedback when I
sent V2 for a quickfix.
I will take care about your comment:
> We need a matching update to the binding document.
>
> This does also seem like a terribly generic name - Google
> suggests that this is actually a series of numbered products (eg,
> Genio 700), perhaps we should be using the specific numbers here?
> I guess users would care which they're talking to. It really
> parses as being "generic I/O" which would be an end run around
> describing the actual product though it's not actually that.
Is there a binding documentation for spidev ? I didn't find it.
My understanding is to have something more specific like:
compatible = "mediatek,genio350"
Or maybe use the SoC name, to be aligned with the DTS ?
compatible = "mediatek,spi-mt8365"
Regards,
Alex
next prev parent reply other threads:[~2023-01-19 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 17:28 [PATCH v2 0/2] Add MediaTek MT8365 SPI support Alexandre Mergnat
2023-01-19 17:28 ` [PATCH v2 1/2] arm64: dts: mediatek: add spidev support for mt8365-evk board Alexandre Mergnat
2023-01-19 17:28 ` [PATCH v2 2/2] spi: spidev: add new mediatek support Alexandre Mergnat
2023-01-19 17:36 ` Mark Brown
2023-01-19 19:30 ` Alexandre Mergnat [this message]
2023-01-20 8:23 ` Krzysztof Kozlowski
2023-01-20 8:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFGrd9pZ0Lso6LMKkN=ErujGgRi6t5_C3FvbMYHaV5V_DD0BnA@mail.gmail.com' \
--to=amergnat@baylibre.com \
--cc=aouledameur@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).