From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE631C004D4 for ; Thu, 19 Jan 2023 19:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbjASTag (ORCPT ); Thu, 19 Jan 2023 14:30:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbjASTaa (ORCPT ); Thu, 19 Jan 2023 14:30:30 -0500 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E759574C for ; Thu, 19 Jan 2023 11:30:28 -0800 (PST) Received: by mail-yb1-xb2c.google.com with SMTP id c124so3847515ybb.13 for ; Thu, 19 Jan 2023 11:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XeirCJAnAvYHJRWOqOsfW1hYyWSjdT+Ia3hbkutfMMQ=; b=W/jc15KxUCWrRIvEx3elqDdDeiflQ65ZJhZp5RrASRAKLlj4zO58m84Vj+u2t+A+Ub LTjFrtDTgJJVd7gYUe/yqMbevOT6+SY5vxKbC7sV8tbxbtrGnJFNe0rIiMVMnvagfgub diSVQG+En5UIkmCkzbRWk08gMCztKdMlKAI9UvkF/hmAgrg0797beeT50QqEuEn0RS40 tm/IcFVo5NUeEC9wdsBVfRhoMpB3tWv36YkrUuG5Gi2AIFAXdIW3wjzmrrB/pXM0V4k5 Zs9zKCNClN4iHq0g6JAKrnC4ukKpMa1cm6cZSasj4Dk1GA4WDzFW5GPg+SYXEq7L2S4J P4Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XeirCJAnAvYHJRWOqOsfW1hYyWSjdT+Ia3hbkutfMMQ=; b=0pPPl/Vy8M7/g2QM4aEHA7L4JsYzXJ8UjF4nujSDSaKeHh1u7yu/wPZmVZ8Gn9e85q Z0t0yz6UB1WLC0Rv7y89Z7xUIp7HAbbvuh4XbFqJltCXfcrsQznDFxSfCPJPMXPP3hin Y9cJBjwN0iazUY/80FPbK7dUg3z5BoDIx4iDOIGqEhzbu6v5KGFBD7W/5Vx6VdBPdPoA JFuWsdRUaqpR2bkM1dHhijhsRX/Vfd6i8KhlNW/l1AybVg5SLnOQz0EWeWD+xfD9SuTq rrdjrXwwZORNyjcem6m93Lkp3lCqzNngk5Hn/hoDqxbSf4rCWk8JTNq2cIL1ufCHh6a0 Zhaw== X-Gm-Message-State: AFqh2kpmEwFnQCiRql7mSuQfFNMVEMvchOaZA7vX01taOcxcIZ5iUoTM LerifrNDAbftFNHLytLZ/iM8Bpl3KaIEU8q5R7Nm7w== X-Google-Smtp-Source: AMrXdXu2hI6GTxFM6roiARVxtIshJOJfKVdp6j55OgzYw67RgQhhNqIbaKmtFdYvzitjyQsXkdo2ssTrJkJ37MisEbw= X-Received: by 2002:a25:9291:0:b0:7c0:563:c516 with SMTP id y17-20020a259291000000b007c00563c516mr1162358ybl.529.1674156627804; Thu, 19 Jan 2023 11:30:27 -0800 (PST) MIME-Version: 1.0 References: <20230118-mt8365-spi-support-v2-0-be3ac97a28c6@baylibre.com> <20230118-mt8365-spi-support-v2-2-be3ac97a28c6@baylibre.com> In-Reply-To: From: Alexandre Mergnat Date: Thu, 19 Jan 2023 20:30:15 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] spi: spidev: add new mediatek support To: Mark Brown Cc: Matthias Brugger , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Amjad Ouled-Ameur , linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Le jeu. 19 janv. 2023 =C3=A0 18:36, Mark Brown a =C3= =A9crit : > > On Thu, Jan 19, 2023 at 06:28:20PM +0100, Alexandre Mergnat wrote: > > Add the "mediatek,genio" compatible string to support Mediatek > > SPI controller on the genio boards. > > All my previous review comments stand, please don't ignore review > feedback. Hi Mark, Yes sorry about that, I wasn't aware that I've some feedback when I sent V2 for a quickfix. I will take care about your comment: > We need a matching update to the binding document. > > This does also seem like a terribly generic name - Google > suggests that this is actually a series of numbered products (eg, > Genio 700), perhaps we should be using the specific numbers here? > I guess users would care which they're talking to. It really > parses as being "generic I/O" which would be an end run around > describing the actual product though it's not actually that. Is there a binding documentation for spidev ? I didn't find it. My understanding is to have something more specific like: compatible =3D "mediatek,genio350" Or maybe use the SoC name, to be aligned with the DTS ? compatible =3D "mediatek,spi-mt8365" Regards, Alex