From: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
To: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFT][PATCH v2] spi: clps711x: refactor to use core message parsing
Date: Tue, 18 Feb 2014 16:52:32 +0800 [thread overview]
Message-ID: <CAFRkauCQkyDFixt-t1Oe9L8eJBdhCeAFMeEBn7KimfcFRcP_ag@mail.gmail.com> (raw)
In-Reply-To: <1392712030.410354049-ah3gxum9muhsdVUOrk1QfQ@public.gmane.org>
2014-02-18 16:27 GMT+08:00 Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>:
> Вторник, 18 февраля 2014, 9:31 +08:00 от Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>:
>> Convert to use default implementation of transfer_one_message() which provides
>> standard handling of delays and chip select management.
>>
>> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
>> ---
> ...
>> static irqreturn_t spi_clps711x_isr(int irq, void *dev_id)
>> {
>> - struct spi_clps711x_data *hw = (struct spi_clps711x_data *)dev_id;
>> + struct spi_master *master = dev_id;
>> + struct spi_clps711x_data *hw = spi_master_get_devdata(master);
>> u8 data;
>>
>> /* Handle RX */
>> @@ -135,7 +113,7 @@ static irqreturn_t spi_clps711x_isr(int irq, void *dev_id)
>> clps_writel(data | SYNCIO_FRMLEN(hw->bpw) | SYNCIO_TXFRMEN,
>> SYNCIO);
>> } else
>> - complete(&hw->done);
>> + complete(&master->xfer_completion);
>
> spi_finalize_current_transfer(master);
It's done by spi core. see spi_transfer_one_message() in spi.c
Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-18 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 1:31 [RFT][PATCH v2] spi: clps711x: refactor to use core message parsing Axel Lin
2014-02-18 8:27 ` Alexander Shiyan
[not found] ` <1392712030.410354049-ah3gxum9muhsdVUOrk1QfQ@public.gmane.org>
2014-02-18 8:52 ` Axel Lin [this message]
[not found] ` <CAFRkauCQkyDFixt-t1Oe9L8eJBdhCeAFMeEBn7KimfcFRcP_ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-18 8:56 ` Alexander Shiyan
[not found] ` <1392713792.597739775-e68EWkKP98BsdVUOrk1QfQ@public.gmane.org>
2014-02-18 8:59 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFRkauCQkyDFixt-t1Oe9L8eJBdhCeAFMeEBn7KimfcFRcP_ag@mail.gmail.com \
--to=axel.lin-8e1dmatc8ynqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shc_work-JGs/UdohzUI@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).