* [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode
@ 2019-08-29 4:16 Rayagonda Kokatanur
2019-08-29 9:59 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Rayagonda Kokatanur @ 2019-08-29 4:16 UTC (permalink / raw)
To: Kamal Dasu, bcm-kernel-feedback-list, Mark Brown, linux-spi,
linux-kernel
Cc: Rayagonda Kokatanur
The spi-nor controller defaults to BSPI mode, hence switch back
to its default mode after MSPI operations (write or erase)
are completed.
Changes from V1:
- Address code review comment from Mark Brown.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/spi/spi-bcm-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index 902bdbf..46a811a 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -897,6 +897,7 @@ static int bcm_qspi_transfer_one(struct spi_master *master,
read_from_hw(qspi, slots);
}
+ bcm_qspi_enable_bspi(qspi);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode
2019-08-29 4:16 [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode Rayagonda Kokatanur
@ 2019-08-29 9:59 ` Mark Brown
2019-08-30 4:36 ` Rayagonda Kokatanur
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2019-08-29 9:59 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Kamal Dasu, bcm-kernel-feedback-list, linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Thu, Aug 29, 2019 at 09:46:13AM +0530, Rayagonda Kokatanur wrote:
> The spi-nor controller defaults to BSPI mode, hence switch back
> to its default mode after MSPI operations (write or erase)
> are completed.
>
> Changes from V1:
> - Address code review comment from Mark Brown.
As covered in submitting-patches.rst inter-version changelogs should go
after the --- so they don't end up in git.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode
2019-08-29 9:59 ` Mark Brown
@ 2019-08-30 4:36 ` Rayagonda Kokatanur
0 siblings, 0 replies; 3+ messages in thread
From: Rayagonda Kokatanur @ 2019-08-30 4:36 UTC (permalink / raw)
To: Mark Brown
Cc: Kamal Dasu, BCM Kernel Feedback, linux-spi,
Linux Kernel Mailing List
On Thu, Aug 29, 2019 at 3:29 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Aug 29, 2019 at 09:46:13AM +0530, Rayagonda Kokatanur wrote:
> > The spi-nor controller defaults to BSPI mode, hence switch back
> > to its default mode after MSPI operations (write or erase)
> > are completed.
> >
> > Changes from V1:
> > - Address code review comment from Mark Brown.
>
> As covered in submitting-patches.rst inter-version changelogs should go
> after the --- so they don't end up in git.
Thank you, I fixed it and sent patch v3 for review.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-30 4:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-29 4:16 [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode Rayagonda Kokatanur
2019-08-29 9:59 ` Mark Brown
2019-08-30 4:36 ` Rayagonda Kokatanur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).