Re: [PATCH v2 1/3] spi: dt-binding: add Microchip CoreQSPI compatible

[naga sureshkumar <nagasuresh12@gmail.com>]

Hi Krzysztof,

Thanks for the review.

On Tue, Aug 2, 2022 at 3:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 02/08/2022 09:05, Naga Sureshkumar Relli wrote:
> > Add compatible string for Microchip CoreQSPI controller.
> >
> > Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
> > ---
> >  .../devicetree/bindings/spi/microchip,mpfs-spi.yaml  | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> > index 7326c0a28d16..8d252eb8c460 100644
> > --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> > @@ -14,9 +14,15 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - microchip,mpfs-spi
> > -      - microchip,mpfs-qspi
> > +    oneOf:
> > +      - description: Microchip's Polarfire SoC QSPI controller.
> > +        items:
> > +          - const: microchip,mpfs-qspi
> > +          - const: microchip,coreqspi-rtl-v2
>
> This is a bit confusing and it is no described in commit msg. You change
>  compatibles for existing binding. This must be a separate commit with
> its own explanation/reasoning.
Ok I will split it and add information in the commit msg.

Thanks,
Naga Sureshkumar Relli.
>
>
> Best regards,
> Krzysztof