From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 05/15] Platform: OLPC: Move OLPC config symbol out of x86 tree Date: Fri, 19 Oct 2018 16:09:17 +0300 Message-ID: References: <20181010172300.317643-1-lkundrak@v3.sk> <20181010172300.317643-6-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Mark Brown , Geert Uytterhoeven , Darren Hart , Andy Shevchenko , Greg Kroah-Hartman , quozl@laptop.org, Sebastian Reichel , Rob Herring , Mark Rutland , Eric Miao , Haojian Zhuang , Daniel Mack , Robert Jarzmik , linux-spi , devicetree , Linux Kernel Mailing List , linux-arm Mailing List , Platform Driver , devel@driverdev.osuosl.or To: Lubomir Rintel Return-path: In-Reply-To: <20181010172300.317643-6-lkundrak@v3.sk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > There are ARM OLPC machines that use mostly the same drivers, including > EC infrastructure, DCON and Battery. > > While at that, fix Kconfig to allow building this as a module. > - depends on MOUSE_PS2 && OLPC > + depends on MOUSE_PS2 && X86 && OLPC > - depends on OLPC && FB > + depends on X86 && OLPC && FB Looking to this I would rather introduce an idiom depends on OLPC && X86 on the opposite you may do similar for ARM depends on OLPC && ARM // or ARM64 or whatever it's called thus, above would look like depends on MOUSE_PS2 depends on OLPC && X86 and depends on FB depends on OLPC && X86 respectively. -- With Best Regards, Andy Shevchenko