From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: lee@kernel.org, broonie@kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes
Date: Thu, 25 Jan 2024 20:52:02 +0200 [thread overview]
Message-ID: <CAHp75VfL2n-zn=cSPULtu1_uRuTNrgtLnJCpSxbiN6xxKzc-JQ@mail.gmail.com> (raw)
In-Reply-To: <20240125102555.2621736-2-ckeepax@opensource.cirrus.com>
On Thu, Jan 25, 2024 at 12:25 PM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.
...
> Changes since v2:
> - Added pm.h and regmap.h back into mfd/cs42l43.h
Btw, TIL that your v1 was fully correct as there is no use of the type
definitions. In case you are going to send v3, you can use v1 of this
patch if you want, this version is also okay (as we have some more
like this pattern, which probably needs to be amended in the future).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-25 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 10:25 [PATCH v3 1/6] spi: cs42l43: Tidy up header includes Charles Keepax
2024-01-25 10:25 ` [PATCH v3 2/6] mfd: " Charles Keepax
2024-01-25 13:55 ` Lee Jones
2024-01-25 18:54 ` Andy Shevchenko
2024-01-26 9:06 ` Lee Jones
2024-01-25 18:52 ` Andy Shevchenko [this message]
2024-01-25 10:25 ` [PATCH v3 3/6] mfd: cs42l43: Use __u8 type rather than u8 for firmware interface Charles Keepax
2024-01-25 10:25 ` [PATCH v3 4/6] mfd: cs42l43: Add time postfixes on defines Charles Keepax
2024-01-25 18:49 ` Andy Shevchenko
2024-01-25 10:25 ` [PATCH v3 5/6] mfd: cs42l43: Add some missing dev_err_probe()s Charles Keepax
2024-01-25 10:25 ` [PATCH v3 6/6] mfd: cs42l43: Handle error from devm_pm_runtime_enable() Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfL2n-zn=cSPULtu1_uRuTNrgtLnJCpSxbiN6xxKzc-JQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).