linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stan Hu <stanhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Shubhrajyoti Datta
	<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 1/1] spi: omap2-mcspi: add option to configure output line for McSPI driver
Date: Tue, 9 Oct 2012 11:40:04 -0700	[thread overview]
Message-ID: <CAMBWrQmuTchn-Hp_AsFGPscT37CWuFSOGWOjNnXEXQUiWvNoWQ@mail.gmail.com> (raw)
In-Reply-To: <CAM=Q2csxH_Mjq1WGR+0xHg8jVVbgGUJ-qP_8UEQ84Ex48fvWwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

The other configuration is used in the case when you have SPI devices wired
opposite to the default case.  This was the case for a custom board using
the McSPI driver.

I tested it by just passing in the parameter in the device config data when
registering the device under the spidev driver.

I noticed a similar patch was submitted recently:

http://sourceforge.net/mailarchive/forum.php?thread_name=1349626784-22035-1-git-send-email-zonque%40gmail.com&forum_name=spi-devel-general

The reason I put it in the device config because I reasoned you could in
theory configure MOSI and MISO differently for each SPI device on the bus.
 This seems unlikely, though, but it is within the power of a hardware
designer to do that.

Feel free to use the other patch if it's more complete.

On Tue, Oct 9, 2012 at 11:28 AM, Shubhrajyoti Datta <
omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Tue, Oct 9, 2012 at 4:09 AM, Stan Hu <stanhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > McSPI driver previously assumed that D0 was input (MISO) and D1 was
> output (MOSI).
> > This forces the hardware designer to wire all SPI peripherals in this
> way when
> > it should be a software configuration option.
>
> Your change looks good.
>
> What is the other configuration used for?
>
> Also are you using a dt patch to test it?
>
> >
> > Signed-off-by: Stan Hu <stanhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
>
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev

  parent reply	other threads:[~2012-10-09 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 22:39 [PATCH 1/1] spi: omap2-mcspi: add option to configure output line for McSPI driver Stan Hu
     [not found] ` <CAM=Q2csxH_Mjq1WGR+0xHg8jVVbgGUJ-qP_8UEQ84Ex48fvWwQ@mail.gmail.com>
     [not found]   ` <CAM=Q2csxH_Mjq1WGR+0xHg8jVVbgGUJ-qP_8UEQ84Ex48fvWwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-09 18:40     ` Stan Hu [this message]
     [not found] ` <1349735980-17015-1-git-send-email-stanhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-17  7:27   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMBWrQmuTchn-Hp_AsFGPscT37CWuFSOGWOjNnXEXQUiWvNoWQ@mail.gmail.com \
    --to=stanhu-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).