From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0116E2C7 for ; Fri, 12 Jan 2024 14:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="neAeT8Xs" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2cd33336b32so86490941fa.0 for ; Fri, 12 Jan 2024 06:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1705071325; x=1705676125; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+L9xJDVEsE7V3csU6sYKZtbMRfUFtdtCzJGzvU7993M=; b=neAeT8XsY2KdELItdqx8vka/T7u8iZ1br+YyzJ66sp++PsaSwbcpzQBbafe7kn4Yup ob/fgH1cbZ54UfcRoXIcwbwIUuEK8cbNxm/y/BAFdWYhGVJ3BPdFwNmGmelgLiylWH6x 5euzjlgFG8peaiL1Yju9cW5Jtnkq9SMTtrUAkkQXjSa1p0A4rUEpOxw3+sZZCgZsYhKG D7U64C3EKTZ1n1p+WGVNduEy2gZHvIlj2/495fUKi/T2zkcJGxDjIvBqS7DclZRZoF3c Vn87/dvtQd6g/ZQZj7yJGLnuF+DFXSqPVvA+lYX847xapKRI0JcVyZsW108ekSQEA+zJ Ya2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705071325; x=1705676125; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+L9xJDVEsE7V3csU6sYKZtbMRfUFtdtCzJGzvU7993M=; b=Tgg0QPgGMDN4FVscTGiDZW0c3JtsdOCkBW1pr8vsK8wXy9RSzfxGmEF+BueL0bVqtO 1BXBbwqoY8nBtOHGQsDOaaII9X7Q9hChoZTH9QOqw4tAjbHCZeaCadtA4DocVjlYphxE p3sSGSKY1EZJyXB660TVWUC805VN3pcF6iu4pLGHyImgk+HtxJd0/y6XL6IOKN6EWjQ9 zSGofx/FuCmjbnUDsdGPk+/Qh6l63Jwy3ERYkR0HyCzUY8Kb1mStjK7HKv3lyOAqlARq LVNSfAnUbUIorslPMGVdqiQDLgKSWB93bEpgcC62X8amfTg0TsVeB87OSuNnqhT6824v cmxQ== X-Gm-Message-State: AOJu0YzfvTMQqa7jLB50yx3m/rWe+FkI7CeotU8SRG3AsOYHvrIMVG5D A2NzIrzZr0TciEdq7eLsA7RfxFrAK6Wy9YJDxIo0qJL700hftg== X-Google-Smtp-Source: AGHT+IHOBCkkSmKcJgoDfFQ2qfKU3lRx2F8RaRRCwSuhk/vh9byUp+s06T/ssB1/fybT50ECpPe/HwOtDD/JTDQsV8Q= X-Received: by 2002:a2e:b0d9:0:b0:2cc:f31b:56ea with SMTP id g25-20020a2eb0d9000000b002ccf31b56eamr844666ljl.92.1705071324606; Fri, 12 Jan 2024 06:55:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240109-axi-spi-engine-series-3-v1-0-e42c6a986580@baylibre.com> <20240109-axi-spi-engine-series-3-v1-10-e42c6a986580@baylibre.com> <20240112123759.00007440@Huawei.com> In-Reply-To: <20240112123759.00007440@Huawei.com> From: David Lechner Date: Fri, 12 Jan 2024 08:55:13 -0600 Message-ID: Subject: Re: [PATCH 10/13] iio: buffer: dmaengine: export devm_iio_dmaengine_buffer_alloc() To: Jonathan Cameron Cc: Mark Brown , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , Frank Rowand , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Jonathan Corbet , linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 6:38=E2=80=AFAM Jonathan Cameron wrote: > > On Wed, 10 Jan 2024 13:49:51 -0600 > David Lechner wrote: > > > This changes devm_iio_dmaengine_buffer_alloc() to an exported symbol. > > This will be used by drivers that need to allocate a DMA buffer without > > attaching it to an IIO device. > > > > Signed-off-by: David Lechner > > --- > > Documentation/driver-api/driver-model/devres.rst | 1 + > > drivers/iio/buffer/Kconfig | 14 +++++++------- > > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 ++- > > include/linux/iio/buffer-dmaengine.h | 2 ++ > > 4 files changed, 12 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documen= tation/driver-api/driver-model/devres.rst > > index b23d4a2b68a6..60e4b7ba38e5 100644 > > --- a/Documentation/driver-api/driver-model/devres.rst > > +++ b/Documentation/driver-api/driver-model/devres.rst > > @@ -285,6 +285,7 @@ I2C > > IIO > > devm_iio_device_alloc() > > devm_iio_device_register() > > + devm_iio_dmaengine_buffer_alloc() > > devm_iio_dmaengine_buffer_setup() > > devm_iio_kfifo_buffer_setup() > > devm_iio_kfifo_buffer_setup_ext() > > diff --git a/drivers/iio/buffer/Kconfig b/drivers/iio/buffer/Kconfig > > index 925c5bf074bc..27d82fb4bc4d 100644 > > --- a/drivers/iio/buffer/Kconfig > > +++ b/drivers/iio/buffer/Kconfig > > @@ -40,6 +40,13 @@ config IIO_BUFFER_HW_CONSUMER > > Should be selected by drivers that want to use the generic Hw c= onsumer > > interface. > > > > +config IIO_HW_TRIGGERED_BUFFER > > + tristate "Industrial I/O hardware triggered buffer support" > > + select AUXILIARY_BUS > > + select IIO_TRIGGER > > + help > > + Provides helper functions for setting up hardware triggered buf= fers. > > + > > config IIO_KFIFO_BUF > > tristate "Industrial I/O buffering based on kfifo" > > help > > @@ -53,10 +60,3 @@ config IIO_TRIGGERED_BUFFER > > select IIO_KFIFO_BUF > > help > > Provides helper functions for setting up triggered buffers. > > - > > -config IIO_HW_TRIGGERED_BUFFER > > - tristate "Industrial I/O hardware triggered buffer support" > > - select AUXILIARY_BUS > > - select IIO_TRIGGER > > - help > > - Provides helper functions for setting up hardware triggered buf= fers. > > Why move this? > Oops, this shouldn't be here. Looks like an artifact from a botched rebase. The intention was to put it in alphabetical order.