linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi/dln2: Fix for PM_RUNTIME removal
@ 2014-12-23  0:29 Mark Brown
       [not found] ` <1419294557-10632-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2014-12-23  0:29 UTC (permalink / raw)
  To: Laurentiu Palcu; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, Mark Brown

Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/spi/spi-dln2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c
index 7b35454..cede063 100644
--- a/drivers/spi/spi-dln2.c
+++ b/drivers/spi/spi-dln2.c
@@ -850,7 +850,7 @@ static int dln2_spi_resume(struct device *dev)
 }
 #endif /* CONFIG_PM_SLEEP */
 
-#ifdef CONFIG_PM_RUNTIME
+#ifdef CONFIG_PM
 static int dln2_spi_runtime_suspend(struct device *dev)
 {
 	struct spi_master *master = dev_get_drvdata(dev);
-- 
2.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi/dln2: Fix for PM_RUNTIME removal
       [not found] ` <1419294557-10632-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2014-12-29 15:03   ` Geert Uytterhoeven
       [not found]     ` <CAMuHMdUeD4dFAxCgK8JO9MS_BCruCJk4AZ29Qr77XpfcgVpnRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-12-29 15:03 UTC (permalink / raw)
  To: Mark Brown; +Cc: Laurentiu Palcu, linux-spi

Hi Mark,

On Tue, Dec 23, 2014 at 1:29 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
>  drivers/spi/spi-dln2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c
> index 7b35454..cede063 100644
> --- a/drivers/spi/spi-dln2.c
> +++ b/drivers/spi/spi-dln2.c
> @@ -850,7 +850,7 @@ static int dln2_spi_resume(struct device *dev)
>  }
>  #endif /* CONFIG_PM_SLEEP */
>
> -#ifdef CONFIG_PM_RUNTIME
> +#ifdef CONFIG_PM
>  static int dln2_spi_runtime_suspend(struct device *dev)
>  {
>         struct spi_master *master = dev_get_drvdata(dev);

You forgot to update the comment for the corresponding #endif a few
lines below:

        #endif /* CONFIG_PM_RUNTIME */

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi/dln2: Fix for PM_RUNTIME removal
       [not found]     ` <CAMuHMdUeD4dFAxCgK8JO9MS_BCruCJk4AZ29Qr77XpfcgVpnRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-12-29 16:03       ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-12-29 16:03 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Laurentiu Palcu, linux-spi

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Mon, Dec 29, 2014 at 04:03:40PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 23, 2014 at 1:29 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> > +#ifdef CONFIG_PM
> >  static int dln2_spi_runtime_suspend(struct device *dev)
> >  {
> >         struct spi_master *master = dev_get_drvdata(dev);

> You forgot to update the comment for the corresponding #endif a few
> lines below:

>         #endif /* CONFIG_PM_RUNTIME */

*sigh* which is one of the many reasons to get annoyed about those
comments; if you care about this please feel free to send a patch.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-29 16:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-23  0:29 [PATCH] spi/dln2: Fix for PM_RUNTIME removal Mark Brown
     [not found] ` <1419294557-10632-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-29 15:03   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdUeD4dFAxCgK8JO9MS_BCruCJk4AZ29Qr77XpfcgVpnRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-29 16:03       ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).