Re: [PATCH v4 8/9] arm64: dts: renesas: sparrow hawk: Add MSIOF Sound support

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Morimoto-san,

On Fri, 18 Apr 2025 at 01:23, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Sparrow Hawk has Headset (CONN3) AUX_IN (CONN4) for Sound input/output
> which is using MSIOF. Support it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts

> @@ -603,6 +655,52 @@ sd_uhs_pins: sd-uhs {
>                 function = "mmc";
>                 power-source = <1800>;
>         };
> +
> +       /* Page 30 / Audio_Codec */
> +       msiof1_pins: sound {
> +               groups = "msiof1_clk", "msiof1_sync", "msiof1_txd", "msiof1_rxd";
> +               function = "msiof1";
> +       };
> +
> +       /* Page 30 / Audio_Codec */
> +       sound_clk_pins: sound-clk {
> +               groups = "audio_clkin", "audio_clkout";
> +               function = "audio_clk";
> +       };
> +};
> +
> +&audio_clkin {
> +       clock-frequency = <24576000>;
> +};

Please keep the nodes sorted (by node name).

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.16, with the sorting fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds