From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Mark Brown <broonie@kernel.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support
Date: Wed, 10 Jun 2020 13:59:24 +0200 [thread overview]
Message-ID: <CAMuHMdWCHeSB9mjpdSX_-qxwo33kMb1_1R93CjBtVBPFPKkEOg@mail.gmail.com> (raw)
In-Reply-To: <20200610110810.GD5005@sirena.org.uk>
Hi Mark,
On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 09, 2020 at 09:54:13PM +0100, Lad Prabhakar wrote:
> > Document RZ/G1H (R8A7742) SoC bindings.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> To repeat my previous feedback I'd expect a driver update as well.
No driver update is needed.
Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says:
compatible:
oneOf:
- items:
- enum:
- renesas,msiof-r8a7742 # RZ/G1H
...
- const: renesas,rcar-gen2-msiof # generic R-Car Gen2 and RZ/G1
# compatible device
drivers/spi/spi-sh-msiof.c matches against "renesas,rcar-gen2-msiof".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-06-10 11:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 20:54 [PATCH 0/2] Add MSIOF support for R8A7742 SOC Lad Prabhakar
2020-06-09 20:54 ` [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support Lad Prabhakar
2020-06-10 8:37 ` Geert Uytterhoeven
2020-06-10 11:08 ` Mark Brown
2020-06-10 11:59 ` Geert Uytterhoeven [this message]
2020-06-10 16:49 ` Mark Brown
2020-06-10 19:18 ` Geert Uytterhoeven
2020-06-11 8:50 ` Mark Brown
2020-06-11 12:09 ` Geert Uytterhoeven
2020-06-16 11:03 ` Mark Brown
2020-06-09 20:54 ` [PATCH 2/2] ARM: dts: r8a7742: Add MSIOF[0123] support Lad Prabhakar
2020-06-26 8:53 ` Geert Uytterhoeven
2020-06-15 23:41 ` [PATCH 0/2] Add MSIOF support for R8A7742 SOC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWCHeSB9mjpdSX_-qxwo33kMb1_1R93CjBtVBPFPKkEOg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).