From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Zhengxun <zhengxunli.mxic@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
zhengxunli <zhengxunli@mxic.com.tw>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
Date: Mon, 23 Aug 2021 13:59:45 +0200 [thread overview]
Message-ID: <CAMuHMdWUVVnZXc4iXrkpyLFpr9w5X-EzuwvvFGQYAp+0=ZJbqw@mail.gmail.com> (raw)
In-Reply-To: <20210818165604.22127-1-zhengxunli.mxic@gmail.com>
CC sergey's new address
On Wed, Aug 18, 2021 at 10:57 AM Zhengxun <zhengxunli.mxic@gmail.com> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
>
> Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
> ---
> drivers/memory/renesas-rpc-if.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
> index 45eed659b0c6..9dd27c6307f7 100644
> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> }
> break;
> default:
> + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> regmap_write(rpc->regmap, RPCIF_SMCR,
> rpc->smcr | RPCIF_SMCR_SPIE);
> --
> 2.17.1
next prev parent reply other threads:[~2021-08-23 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 16:56 [PATCH] memory: renesas-rpc-if: Fix missing setting address Zhengxun
2021-08-23 11:59 ` Geert Uytterhoeven [this message]
2022-04-27 10:26 ` Geert Uytterhoeven
2022-04-27 10:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWUVVnZXc4iXrkpyLFpr9w5X-EzuwvvFGQYAp+0=ZJbqw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=zhengxunli.mxic@gmail.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).