From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] spi: Convert to using %pOF instead of full_name Date: Wed, 19 Jul 2017 11:16:04 +0200 Message-ID: References: <20170718214339.7774-51-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Mark Brown , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-spi To: Rob Herring Return-path: In-Reply-To: <20170718214339.7774-51-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Jul 18, 2017 at 11:43 PM, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring Reviewed-by: Geert Uytterhoeven > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1583,8 +1583,8 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi, > > if (spi_controller_is_slave(ctlr)) { > if (strcmp(nc->name, "slave")) { > - dev_err(&ctlr->dev, "%s is not called 'slave'\n", > - nc->full_name); > + dev_err(&ctlr->dev, "%pOF is not called 'slave'\n", > + nc); I think this can be merged in a single line (more below). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html